This is an archive of the discontinued LLVM Phabricator instance.

[X86] Check if struct is blank before getting the inner types
ClosedPublic

Authored by pengfei on Oct 3 2021, 11:24 PM.

Event Timeline

pengfei requested review of this revision.Oct 3 2021, 11:24 PM
pengfei created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 3 2021, 11:24 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
LuoYuanke added inline comments.Oct 7 2021, 7:40 PM
clang/test/CodeGen/X86/avx512fp16-abi.c
203

Add more cases for the struct composed of _Float16, float, double, struct {}?

pengfei updated this revision to Diff 378082.Oct 7 2021, 8:38 PM
pengfei marked an inline comment as done.

Add more tests. NFC.

LuoYuanke added inline comments.Oct 7 2021, 10:33 PM
clang/test/CodeGen/X86/avx512fp16-abi.c
207

Why not test CPP as well?

pengfei added inline comments.Oct 7 2021, 11:23 PM
clang/test/CodeGen/X86/avx512fp16-abi.c
207

CPP doesn't allow unnamed struct defined in the result type. I can change them to named struct.

pengfei updated this revision to Diff 378102.Oct 7 2021, 11:24 PM

Use named struct to check CPP as well.

LuoYuanke accepted this revision.Oct 8 2021, 12:01 AM

LGTM, thanks.

This revision is now accepted and ready to land.Oct 8 2021, 12:01 AM
This revision was landed with ongoing or failed builds.Oct 8 2021, 2:09 AM
This revision was automatically updated to reflect the committed changes.