This is an archive of the discontinued LLVM Phabricator instance.

Use standard separator for TSan options in `stress.cpp` test case.
ClosedPublic

Authored by delcypher on Oct 1 2021, 1:12 PM.

Details

Summary

Use of space as a separator for options is problematic for wrapper
scripts (i.e. implementations of %run) that have to marshall
environment variables to target different than the host.

Rather than requiring every implementation of %run to support spaces
in TSAN_OPTIONS it is simpler to fix this single test case.

rdar://83637067

Diff Detail

Event Timeline

delcypher requested review of this revision.Oct 1 2021, 1:12 PM
delcypher created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 1 2021, 1:12 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
dvyukov accepted this revision.Oct 2 2021, 2:05 AM

It would be useful if the standard %run would detect this problem and fail.

This revision is now accepted and ready to land.Oct 2 2021, 2:05 AM

It would be useful if the standard %run would detect this problem and fail.

Thanks for the review. While I agree this would be useful I don't think this problem happens frequently enough to justify implementing what you suggested. If it continues to be a problem we can certainly revisit this.