This is an archive of the discontinued LLVM Phabricator instance.

Differential D110966

[X86][Costmodel] Load/store i8 Stride=4 VF=2 interleaving costs
ClosedPublic

Authored by lebedev.ri on Oct 1 2021, 1:12 PM.

Details

Reviewers
RKSimon
Commits
rG935b9693aea1: [X86][Costmodel] Load/store i8 Stride=4 VF=2 interleaving costs
Summary

While we already model this tuple, the values are divergent from reality, so fix them.

The only sched models that for cpu's that support avx2
but not avx512 are: haswell, broadwell, skylake, zen1-3

For load we have:
https://godbolt.org/z/KP6nn36zs - for intels Block RThroughput: =4.0; for ryzens, Block RThroughput: <=2.0
So pick cost of 4.

For store we have:
https://godbolt.org/z/ov95zhrq6 - for intels Block RThroughput: =4.0; for ryzens, Block RThroughput: <=2.0
So pick cost of 4.

I'm directly using the shuffling asm the llc produced,
without any manual fixups that may be needed
to ensure sequential execution.

Diff Detail

Event Timeline

lebedev.ri created this revision.Oct 1 2021, 1:12 PM
Herald added subscribers: pengfei, hiraditya. · View Herald TranscriptOct 1 2021, 1:12 PM
lebedev.ri requested review of this revision.Oct 1 2021, 1:12 PM
lebedev.ri edited the summary of this revision. (Show Details)Oct 1 2021, 1:16 PM
lebedev.ri added a child revision: D110968: [X86][Costmodel] Load/store i8 Stride=4 VF=4 interleaving costs.
RKSimon accepted this revision.Oct 2 2021, 3:19 AM

LGTM

This revision is now accepted and ready to land.Oct 2 2021, 3:19 AM
Closed by commit rG935b9693aea1: [X86][Costmodel] Load/store i8 Stride=4 VF=2 interleaving costs (authored by lebedev.ri). · Explain WhyOct 2 2021, 3:52 AM
This revision was automatically updated to reflect the committed changes.
lebedev.ri added a commit: rG935b9693aea1: [X86][Costmodel] Load/store i8 Stride=4 VF=2 interleaving costs.

Revision Contents

PathSize
llvm/
lib/
Target/
X86/
4 lines
test/
Analysis/
CostModel/
X86/
2 lines
2 lines

Diff 376694

llvm/lib/Target/X86/X86TargetTransformInfo.cpp

Show First 20 Lines • Show All 5,088 Lines • ▼ Show 20 Lines static const CostTblEntry AVX2InterleavedLoadTbl[] = {
{3, MVT::v2i8, 3}, // (load 6i8 and) deinterleave into 3 x 2i8 {3, MVT::v2i8, 3}, // (load 6i8 and) deinterleave into 3 x 2i8
{3, MVT::v4i8, 3}, // (load 12i8 and) deinterleave into 3 x 4i8 {3, MVT::v4i8, 3}, // (load 12i8 and) deinterleave into 3 x 4i8
{3, MVT::v8i8, 6}, // (load 24i8 and) deinterleave into 3 x 8i8 {3, MVT::v8i8, 6}, // (load 24i8 and) deinterleave into 3 x 8i8
{3, MVT::v16i8, 11}, // (load 48i8 and) deinterleave into 3 x 16i8 {3, MVT::v16i8, 11}, // (load 48i8 and) deinterleave into 3 x 16i8
{3, MVT::v32i8, 14}, // (load 96i8 and) deinterleave into 3 x 32i8 {3, MVT::v32i8, 14}, // (load 96i8 and) deinterleave into 3 x 32i8
{3, MVT::v8i32, 17}, // (load 24i32 and) deinterleave into 3 x 8i32 {3, MVT::v8i32, 17}, // (load 24i32 and) deinterleave into 3 x 8i32
{4, MVT::v2i8, 12}, // (load 8i8 and) deinterleave into 4 x 2i8 {4, MVT::v2i8, 4}, // (load 8i8 and) deinterleave into 4 x 2i8
{4, MVT::v4i8, 4}, // (load 16i8 and) deinterleave into 4 x 4i8 {4, MVT::v4i8, 4}, // (load 16i8 and) deinterleave into 4 x 4i8
{4, MVT::v8i8, 20}, // (load 32i8 and) deinterleave into 4 x 8i8 {4, MVT::v8i8, 20}, // (load 32i8 and) deinterleave into 4 x 8i8
{4, MVT::v16i8, 39}, // (load 64i8 and) deinterleave into 4 x 16i8 {4, MVT::v16i8, 39}, // (load 64i8 and) deinterleave into 4 x 16i8
{4, MVT::v32i8, 80}, // (load 128i8 and) deinterleave into 4 x 32i8 {4, MVT::v32i8, 80}, // (load 128i8 and) deinterleave into 4 x 32i8
{4, MVT::v2i16, 6}, // (load 8i16 and) deinterleave into 4 x 2i16 {4, MVT::v2i16, 6}, // (load 8i16 and) deinterleave into 4 x 2i16
{4, MVT::v4i16, 17}, // (load 16i16 and) deinterleave into 4 x 4i16 {4, MVT::v4i16, 17}, // (load 16i16 and) deinterleave into 4 x 4i16
{4, MVT::v8i16, 33}, // (load 32i16 and) deinterleave into 4 x 8i16 {4, MVT::v8i16, 33}, // (load 32i16 and) deinterleave into 4 x 8i16
Show All 33 Lines static const CostTblEntry AVX2InterleavedStoreTbl[] = {
{2, MVT::v16i64, 16}, // interleave 2 x 16i64 into 32i64 (and store) {2, MVT::v16i64, 16}, // interleave 2 x 16i64 into 32i64 (and store)
{3, MVT::v2i8, 4}, // interleave 3 x 2i8 into 6i8 (and store) {3, MVT::v2i8, 4}, // interleave 3 x 2i8 into 6i8 (and store)
{3, MVT::v4i8, 4}, // interleave 3 x 4i8 into 12i8 (and store) {3, MVT::v4i8, 4}, // interleave 3 x 4i8 into 12i8 (and store)
{3, MVT::v8i8, 6}, // interleave 3 x 8i8 into 24i8 (and store) {3, MVT::v8i8, 6}, // interleave 3 x 8i8 into 24i8 (and store)
{3, MVT::v16i8, 11}, // interleave 3 x 16i8 into 48i8 (and store) {3, MVT::v16i8, 11}, // interleave 3 x 16i8 into 48i8 (and store)
{3, MVT::v32i8, 13}, // interleave 3 x 32i8 into 96i8 (and store) {3, MVT::v32i8, 13}, // interleave 3 x 32i8 into 96i8 (and store)
{4, MVT::v2i8, 12}, // interleave 4 x 2i8 into 8i8 (and store) {4, MVT::v2i8, 4}, // interleave 4 x 2i8 into 8i8 (and store)
{4, MVT::v4i8, 9}, // interleave 4 x 4i8 into 16i8 (and store) {4, MVT::v4i8, 9}, // interleave 4 x 4i8 into 16i8 (and store)
{4, MVT::v8i8, 10}, // interleave 4 x 8i8 into 32i8 (and store) {4, MVT::v8i8, 10}, // interleave 4 x 8i8 into 32i8 (and store)
{4, MVT::v16i8, 10}, // interleave 4 x 16i8 into 64i8 (and store) {4, MVT::v16i8, 10}, // interleave 4 x 16i8 into 64i8 (and store)
{4, MVT::v32i8, 12}, // interleave 4 x 32i8 into 128i8 (and store) {4, MVT::v32i8, 12}, // interleave 4 x 32i8 into 128i8 (and store)
{4, MVT::v2i16, 2}, // interleave 4 x 2i16 into 8i16 (and store) {4, MVT::v2i16, 2}, // interleave 4 x 2i16 into 8i16 (and store)
{4, MVT::v4i16, 6}, // interleave 4 x 4i16 into 16i16 (and store) {4, MVT::v4i16, 6}, // interleave 4 x 4i16 into 16i16 (and store)
{4, MVT::v8i16, 10}, // interleave 4 x 8i16 into 32i16 (and store) {4, MVT::v8i16, 10}, // interleave 4 x 8i16 into 32i16 (and store)
▲ Show 20 Lines • Show All 179 Lines • Show Last 20 Lines

llvm/test/Analysis/CostModel/X86/interleaved-load-i8-stride-4.ll

Show All 20 Lines
; AVX1: LV: Found an estimated cost of 1 for VF 1 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX1: LV: Found an estimated cost of 1 for VF 1 For instruction: %v0 = load i8, i8* %in0, align 1
; AVX1: LV: Found an estimated cost of 17 for VF 2 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX1: LV: Found an estimated cost of 17 for VF 2 For instruction: %v0 = load i8, i8* %in0, align 1
; AVX1: LV: Found an estimated cost of 33 for VF 4 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX1: LV: Found an estimated cost of 33 for VF 4 For instruction: %v0 = load i8, i8* %in0, align 1
; AVX1: LV: Found an estimated cost of 81 for VF 8 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX1: LV: Found an estimated cost of 81 for VF 8 For instruction: %v0 = load i8, i8* %in0, align 1
; AVX1: LV: Found an estimated cost of 162 for VF 16 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX1: LV: Found an estimated cost of 162 for VF 16 For instruction: %v0 = load i8, i8* %in0, align 1
; AVX1: LV: Found an estimated cost of 332 for VF 32 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX1: LV: Found an estimated cost of 332 for VF 32 For instruction: %v0 = load i8, i8* %in0, align 1
; ;
; AVX2: LV: Found an estimated cost of 1 for VF 1 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX2: LV: Found an estimated cost of 1 for VF 1 For instruction: %v0 = load i8, i8* %in0, align 1
; AVX2: LV: Found an estimated cost of 13 for VF 2 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX2: LV: Found an estimated cost of 5 for VF 2 For instruction: %v0 = load i8, i8* %in0, align 1
; AVX2: LV: Found an estimated cost of 5 for VF 4 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX2: LV: Found an estimated cost of 5 for VF 4 For instruction: %v0 = load i8, i8* %in0, align 1
; AVX2: LV: Found an estimated cost of 21 for VF 8 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX2: LV: Found an estimated cost of 21 for VF 8 For instruction: %v0 = load i8, i8* %in0, align 1
; AVX2: LV: Found an estimated cost of 41 for VF 16 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX2: LV: Found an estimated cost of 41 for VF 16 For instruction: %v0 = load i8, i8* %in0, align 1
; AVX2: LV: Found an estimated cost of 84 for VF 32 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX2: LV: Found an estimated cost of 84 for VF 32 For instruction: %v0 = load i8, i8* %in0, align 1
; ;
; AVX512: LV: Found an estimated cost of 1 for VF 1 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX512: LV: Found an estimated cost of 1 for VF 1 For instruction: %v0 = load i8, i8* %in0, align 1
; AVX512: LV: Found an estimated cost of 5 for VF 2 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX512: LV: Found an estimated cost of 5 for VF 2 For instruction: %v0 = load i8, i8* %in0, align 1
; AVX512: LV: Found an estimated cost of 5 for VF 4 For instruction: %v0 = load i8, i8* %in0, align 1 ; AVX512: LV: Found an estimated cost of 5 for VF 4 For instruction: %v0 = load i8, i8* %in0, align 1
▲ Show 20 Lines • Show All 43 Lines • Show Last 20 Lines

llvm/test/Analysis/CostModel/X86/interleaved-store-i8-stride-4.ll

Show All 20 Lines
; AVX1: LV: Found an estimated cost of 1 for VF 1 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX1: LV: Found an estimated cost of 1 for VF 1 For instruction: store i8 %v3, i8* %out3, align 1
; AVX1: LV: Found an estimated cost of 17 for VF 2 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX1: LV: Found an estimated cost of 17 for VF 2 For instruction: store i8 %v3, i8* %out3, align 1
; AVX1: LV: Found an estimated cost of 33 for VF 4 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX1: LV: Found an estimated cost of 33 for VF 4 For instruction: store i8 %v3, i8* %out3, align 1
; AVX1: LV: Found an estimated cost of 67 for VF 8 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX1: LV: Found an estimated cost of 67 for VF 8 For instruction: store i8 %v3, i8* %out3, align 1
; AVX1: LV: Found an estimated cost of 134 for VF 16 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX1: LV: Found an estimated cost of 134 for VF 16 For instruction: store i8 %v3, i8* %out3, align 1
; AVX1: LV: Found an estimated cost of 332 for VF 32 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX1: LV: Found an estimated cost of 332 for VF 32 For instruction: store i8 %v3, i8* %out3, align 1
; ;
; AVX2: LV: Found an estimated cost of 1 for VF 1 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX2: LV: Found an estimated cost of 1 for VF 1 For instruction: store i8 %v3, i8* %out3, align 1
; AVX2: LV: Found an estimated cost of 13 for VF 2 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX2: LV: Found an estimated cost of 5 for VF 2 For instruction: store i8 %v3, i8* %out3, align 1
; AVX2: LV: Found an estimated cost of 10 for VF 4 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX2: LV: Found an estimated cost of 10 for VF 4 For instruction: store i8 %v3, i8* %out3, align 1
; AVX2: LV: Found an estimated cost of 11 for VF 8 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX2: LV: Found an estimated cost of 11 for VF 8 For instruction: store i8 %v3, i8* %out3, align 1
; AVX2: LV: Found an estimated cost of 12 for VF 16 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX2: LV: Found an estimated cost of 12 for VF 16 For instruction: store i8 %v3, i8* %out3, align 1
; AVX2: LV: Found an estimated cost of 16 for VF 32 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX2: LV: Found an estimated cost of 16 for VF 32 For instruction: store i8 %v3, i8* %out3, align 1
; ;
; AVX512: LV: Found an estimated cost of 1 for VF 1 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX512: LV: Found an estimated cost of 1 for VF 1 For instruction: store i8 %v3, i8* %out3, align 1
; AVX512: LV: Found an estimated cost of 11 for VF 2 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX512: LV: Found an estimated cost of 11 for VF 2 For instruction: store i8 %v3, i8* %out3, align 1
; AVX512: LV: Found an estimated cost of 11 for VF 4 For instruction: store i8 %v3, i8* %out3, align 1 ; AVX512: LV: Found an estimated cost of 11 for VF 4 For instruction: store i8 %v3, i8* %out3, align 1
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines