[compiler-rt][profile] Enable profile tests for AIX

[jsji]

Summary

This patch enable profile test for supported options on AIX.

[jsji]

Ping..

[w2yehia]

compiler-rt/test/profile/instrprof-set-dir-mode.c

37

I'm wondering if this can break other platforms. Is it guaranteed (by some standard) that the high order 16-bits are never used by st_mode?
If S_IFDIR has 1s in the high order 16 bits, then Mode has ones there as well; ~umask will have 1s in the high order 16 bits. So masking with 0xFFFF wud not be correct in that case.

compiler-rt/test/profile/lit.cfg.py

63

filename wud not be unique, why not stove source_path instead?

[w2yehia]

LGTM if concerns are resolved.

[jsji]

compiler-rt/test/profile/instrprof-set-dir-mode.c

37

S_IFDIR is 0040000 (octal), which is 0x4000 in hex. And yes, there are higher order 16bits are never used by st_mode other than AIX.

37

And yes, higher order 16bits are never used by st_mode other than AIX.

[jsji]

compiler-rt/test/profile/lit.cfg.py

63

We can NOT use source_path.

excludes are designed to be filename.

# Search subdirectories.
for filename in os.listdir(source_path):
      if ... filename in lc.excludes:
          continue

compiler-rt/test/profile/instrprof-set-dir-mode.c

else {
     // From 'man mkdir':
     // "If the parent directory has the set-group-ID bit set, then so will the
     // newly created directory."  So we mask off S_ISGID below; this test cannot
     // control its parent directory.
     const unsigned Expected = ~umask(0) & Mode;
     struct stat DirSt;
     if (stat(Dir, &DirSt) == -1)
       Ret = -1;
-    else if ((DirSt.st_mode & ~S_ISGID) != Expected) {
+    // AIX has some extended definition of high order bits for st_mode, avoid trying to comparing those by masking them off.
+    else if (((DirSt.st_mode & ~S_ISGID) & 0xFFFF) != Expected) {
       printf("Modes do not match: Expected %o but found %o (%s)\n", Expected,
              DirSt.st_mode, Dir);
       Ret = -1;
     }
   }
 
   free(Dir);
   return Ret;
 }
 
 int main(void) {
   if (test(S_IFDIR | 0777, TESTPATH "/foo/bar/baz/") ||
       test(S_IFDIR | 0666, TESTPATH "/foo/bar/qux/"))
     return -1;
   return 0;
 }

compiler-rt/test/profile/instrprof-set-file-object-merging.c

 // Test that the specified output merges the profiling data.
 // Run the program twice so that the counters accumulate.
-// RUN: %clang -fprofile-instr-generate -fcoverage-mapping -o %t %s
+// RUN: %clang_profgen -fcoverage-mapping -o %t %s
 // RUN: rm -f %t.merging.profraw %t.merging.profdata
 // RUN: %run %t %t.merging.profraw
 // RUN: %run %t %t.merging.profraw
 // RUN: test -f %t.merging.profraw
 // RUN: llvm-profdata merge -o %t.merging.profdata %t.merging.profraw
 // RUN: llvm-cov show -instr-profile %t.merging.profdata %t | FileCheck %s --match-full-lines
 #include <stdio.h>
 

compiler-rt/test/profile/instrprof-set-file-object.c

 // Test that the specified output has profiling data.
-// RUN: %clang -fprofile-instr-generate -fcoverage-mapping -o %t %s
+// RUN: %clang_profgen -fcoverage-mapping -o %t %s
 // RUN: %run %t %t.file.profraw
 // RUN: test -f %t.file.profraw
 // RUN: llvm-profdata merge -o %t.file.profdata %t.file.profraw
 // RUN: llvm-cov show -instr-profile %t.file.profdata %t | FileCheck %s --match-full-lines
 // RUN: rm %t.file.profraw %t.file.profdata
 #include <stdio.h>
 
 extern void __llvm_profile_set_file_object(FILE *, int);

compiler-rt/test/profile/lit.cfg.py

 def build_invocation(compile_flags, with_lto = False):
   lto_flags = []
   lto_prefix = []
   if with_lto and config.lto_supported:
     lto_flags += config.lto_flags
     lto_prefix += config.lto_launch
   return " " + " ".join(lto_prefix + [config.clang] + lto_flags + compile_flags) + " "
 
+def exclude_unsupported_files_for_aix(dirname):
+   for filename in os.listdir(dirname):
+       source_path = os.path.join( dirname, filename)
+       if os.path.isdir(source_path):
+           continue
+       f = open(source_path, 'r')
+       try:
+          data = f.read()
+          # -fprofile-instr-generate and rpath are not supported on AIX, exclude all tests with them.
+          if ("%clang_profgen" in data or "%clangxx_profgen" in data or "-rpath" in data):
+            config.excludes += [ filename ]
+       finally:
+          f.close()
+
 # Add clang substitutions.
 config.substitutions.append( ("%clang ", build_invocation(clang_cflags)) )
 config.substitutions.append( ("%clangxx ", build_invocation(clang_cxxflags)) )
 config.substitutions.append( ("%clang_profgen ", build_invocation(clang_cflags) + " -fprofile-instr-generate ") )
 config.substitutions.append( ("%clang_profgen=", build_invocation(clang_cflags) + " -fprofile-instr-generate=") )
 config.substitutions.append( ("%clang_pgogen ", build_invocation(clang_cflags) + " -fprofile-generate ") )
 config.substitutions.append( ("%clang_pgogen=", build_invocation(clang_cflags) + " -fprofile-generate=") )
 
 config.substitutions.append( ("%clangxx_profgen ", build_invocation(clang_cxxflags) + " -fprofile-instr-generate ") )
 config.substitutions.append( ("%clangxx_profgen=", build_invocation(clang_cxxflags) + " -fprofile-instr-generate=") )
 config.substitutions.append( ("%clangxx_pgogen ", build_invocation(clang_cxxflags) + " -fprofile-generate ") )
 config.substitutions.append( ("%clangxx_pgogen=", build_invocation(clang_cxxflags) + " -fprofile-generate=") )
 
 config.substitutions.append( ("%clang_profgen_gcc=", build_invocation(clang_cflags) + " -fprofile-generate=") )
 config.substitutions.append( ("%clang_profuse_gcc=", build_invocation(clang_cflags) + " -fprofile-use=") )
 
 config.substitutions.append( ("%clang_profuse=", build_invocation(clang_cflags) + " -fprofile-instr-use=") )
 config.substitutions.append( ("%clangxx_profuse=", build_invocation(clang_cxxflags) + " -fprofile-instr-use=") )
 
 config.substitutions.append( ("%clang_lto_profgen=", build_invocation(clang_cflags, True) + " -fprofile-instr-generate=") )
 
-if config.host_os not in ['Windows', 'Darwin', 'FreeBSD', 'Linux', 'NetBSD', 'SunOS']:
+if config.host_os not in ['Windows', 'Darwin', 'FreeBSD', 'Linux', 'NetBSD', 'SunOS', 'AIX']:
   config.unsupported = True
 
+if config.host_os in ['AIX']:
+  config.available_features.add('system-aix')
+  exclude_unsupported_files_for_aix(config.test_source_root)
+  exclude_unsupported_files_for_aix(config.test_source_root + "/Posix")
+
 if config.target_arch in ['armv7l']:
   config.unsupported = True
 
 if config.android:
   config.unsupported = True