This is an archive of the discontinued LLVM Phabricator instance.

Differential D110881

[CMake] Remove the LLD LTO check for Darwin
ClosedPublic

Authored by phosek on Sep 30 2021, 1:43 PM.

Details

Reviewers
smeenai
Commits
rG0c4a75f193a7: [CMake] Remove the LLD LTO check for Darwin
Summary

LLD now supports LTO on Darwin.

Diff Detail

Event Timeline

phosek created this revision.Sep 30 2021, 1:43 PM
Herald added subscribers: inglorion, mgorny. · View Herald TranscriptSep 30 2021, 1:43 PM
phosek requested review of this revision.Sep 30 2021, 1:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2021, 1:43 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
smeenai accepted this revision.Sep 30 2021, 1:56 PM
smeenai added a subscriber: Restricted Project.

LGTM

This revision is now accepted and ready to land.Sep 30 2021, 1:56 PM
Closed by commit rG0c4a75f193a7: [CMake] Remove the LLD LTO check for Darwin (authored by phosek). · Explain WhySep 30 2021, 2:00 PM
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rG0c4a75f193a7: [CMake] Remove the LLD LTO check for Darwin.

Revision Contents

PathSize
llvm/
cmake/
modules/
3 lines

Diff 376348

llvm/cmake/modules/HandleLLVMOptions.cmake

Show First 20 Lines • Show All 161 Lines • ▼ Show 20 Lines
# We use *.dylib rather than *.so on darwin, but we stick with *.so on AIX. # We use *.dylib rather than *.so on darwin, but we stick with *.so on AIX.
if(${CMAKE_SYSTEM_NAME} MATCHES "AIX") if(${CMAKE_SYSTEM_NAME} MATCHES "AIX")
set(LLVM_PLUGIN_EXT ${CMAKE_SHARED_MODULE_SUFFIX}) set(LLVM_PLUGIN_EXT ${CMAKE_SHARED_MODULE_SUFFIX})
else() else()
set(LLVM_PLUGIN_EXT ${CMAKE_SHARED_LIBRARY_SUFFIX}) set(LLVM_PLUGIN_EXT ${CMAKE_SHARED_LIBRARY_SUFFIX})
endif() endif()
if(APPLE) if(APPLE)
if(LLVM_ENABLE_LLD AND LLVM_ENABLE_LTO)
message(FATAL_ERROR "lld does not support LTO on Darwin")
endif()
# Darwin-specific linker flags for loadable modules. # Darwin-specific linker flags for loadable modules.
set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-flat_namespace -Wl,-undefined -Wl,suppress") set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-flat_namespace -Wl,-undefined -Wl,suppress")
endif() endif()
if(${CMAKE_SYSTEM_NAME} MATCHES "Linux") if(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
# RHEL7 has ar and ranlib being non-deterministic by default. The D flag forces determinism, # RHEL7 has ar and ranlib being non-deterministic by default. The D flag forces determinism,
# however only GNU version of ar and ranlib (2.27) have this option. # however only GNU version of ar and ranlib (2.27) have this option.
# RHEL DTS7 is also affected by this, which uses GNU binutils 2.28 # RHEL DTS7 is also affected by this, which uses GNU binutils 2.28
▲ Show 20 Lines • Show All 1,044 Lines • Show Last 20 Lines