This is an archive of the discontinued LLVM Phabricator instance.

Unbreak WebAssembly build
ClosedPublic

Authored by jfb on Jul 9 2015, 1:45 PM.

Details

Summary

D11021 and D11045 didn't update the WebAssembly target's code. It's still experimental so all tests passed.

Diff Detail

Event Timeline

jfb updated this revision to Diff 29383.Jul 9 2015, 1:45 PM
jfb retitled this revision from to Unbreak WebAssembly build.
jfb updated this object.
jfb added reviewers: sunfish, mehdi_amini, echristo.
jfb added a subscriber: llvm-commits.
mehdi_amini accepted this revision.Jul 9 2015, 1:47 PM
mehdi_amini edited edge metadata.

LGTM.
Sorry about that, I'll enable experimental for my future change on this topic.

This revision is now accepted and ready to land.Jul 9 2015, 1:47 PM
echristo edited edge metadata.Jul 9 2015, 1:49 PM

Looks like you can just delete the web assembly specific selectiondag info?

jfb added a comment.Jul 9 2015, 1:51 PM

Looks like you can just delete the web assembly specific selectiondag info?

For now we could, but I expect we'll add it back later? The target is missing a lot of stuff for now!

sunfish edited edge metadata.Jul 9 2015, 1:56 PM

This codegen is under construction :-). WebAssemblySelectionDAGInfo will eventually want to override EmitTargetCodeForMemset and other functions.

echristo accepted this revision.Jul 9 2015, 1:57 PM
echristo edited edge metadata.

Sure, OK I guess. Just seemed like a waste to update dead (for now) code.

-eric

jfb added a comment.Jul 9 2015, 1:59 PM

Sure, OK I guess. Just seemed like a waste to update dead (for now) code.

-eric

It turns out the code isn't *quite* dead ;-)

This revision was automatically updated to reflect the committed changes.