[CUDA] Make sure <string.h> is included with original __THROW defined.

[tra]

Summary

Otherwise we may end up with an inconsistent redeclarations of the standard
library functions if _FORTIFY_SOURCE is in effect.

Fixes https://bugs.llvm.org/show_bug.cgi?id=47869

[tra]

@jdoerfert: Ping. I think you're the best match for reviewing the code related to interaction between CUDA and the system include files, even if this particular header does not have much to do with OpenMP.

[jdoerfert]

I first had to read up on pop_macro -.-. Still unsure if it is OK to push it once and pop it twice, that works fine?
Can't we move the string include earlier, grouped with stdlib and cmath? then we don't need to play with THROW twice.
Other than that it seems sensible to let string have a THROW, even though none of this mismatch is really sensible at the end of the day...

While we are here, we should be able to have a test, no? Something in string.h that depends on __THROW being present should suffice I guess.

[tra]

Added a missing push_macro

[tra]

re-set __THROW to an empty value. It's still needed for CUDA-7.5

[tra]

Moved string.h inclusion to the top of the file.

[tra]

In D110781#3045280, @jdoerfert wrote:

I first had to read up on pop_macro -.-. Still unsure if it is OK to push it once and pop it twice, that works fine?

Good catch.

Can't we move the string include earlier, grouped with stdlib and cmath? then we don't need to play with __THROW twice.

Indeed, that's a better fix. I've updated the patch.

Other than that it seems sensible to let string have a __THROW, even though none of this mismatch is really sensible at the end of the day...

While we are here, we should be able to have a test, no? Something in string.h that depends on __THROW being present should suffice I guess.

Tests for this header are hard to do in-tree as the header is intended to interact with the specific CUDA SDK headers.
All this is tested on CUDA buildbots running test-suite and compiles the tests with multiple CUDA versions.
If we get __THROW wrong where it matters, we'll end up with compiler complaining about the mismatch, like it did in the bug report that prompted this patch.

[jdoerfert]

LG. Always including string (probably) won't hurt given the stuff we do here already.

clang/lib/Headers/__clang_cuda_runtime_wrapper.h

 // CUDA.
 #define __CUDACC__
 
 // Include some standard headers to avoid CUDA headers including them
 // while some required macros (like __THROW) are in a weird state.
 #include <cmath>
 #include <cstdlib>
 #include <stdlib.h>
+#include <string.h>
 #undef __CUDACC__
 
 // Preserve common macros that will be changed below by us or by CUDA
 // headers.
 #pragma push_macro("__THROW")
 #pragma push_macro("__CUDA_ARCH__")
 
 // WARNING: Preprocessor hacks below are based on specific details of

 // device_functions.hpp uses __USE_FAST_MATH__ for a different purpose (fast vs.
 // slow divides), so we need to scope our define carefully here.
 #pragma push_macro("__USE_FAST_MATH__")
 #if defined(__CLANG_CUDA_APPROX_TRANSCENDENTALS__)
 #define __USE_FAST_MATH__ 1
 #endif
 
 #if CUDA_VERSION >= 9000
-// CUDA-9.2 needs host-side memcpy for some host functions in
-// device_functions.hpp
-#if CUDA_VERSION >= 9020
-#include <string.h>
-#endif
 #include "crt/math_functions.hpp"
 #else
 #include "math_functions.hpp"
 #endif
 
 #pragma pop_macro("__USE_FAST_MATH__")
 
 #if CUDA_VERSION < 9000