This is an archive of the discontinued LLVM Phabricator instance.

[libc++][Docs] Update benchmark doc wrt monorepo
ClosedPublic

Authored by xgupta on Sep 29 2021, 8:15 AM.

Details

Summary

Seems this section is not updated since we have transited to llvm-project monorepo.
At the start, we build libcxx under monorepo configuration but later try to make the separate configuration for libcxx build
and running benchmark.

Diff Detail

Event Timeline

xgupta requested review of this revision.Sep 29 2021, 8:15 AM
xgupta created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2021, 8:15 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
xgupta retitled this revision from [libc++][Docs] Update benchmark doc wrt to monorepo to [libc++][Docs] Update benchmark doc wrt monorepo.Sep 29 2021, 8:37 AM
xgupta edited the summary of this revision. (Show Details)

Thanks for working on this!

libcxx/docs/TestingLibcxx.rst
230

Since our build documentation now uses ninja (https://libcxx.llvm.org/BuildingLibcxx.html#bootstrapping-build) I think it would be nice to change these instructions to ninja.

230

I don't mind removing this line, but I think the documentation should make it clear build directory already contains a generated CMake project.

xgupta added inline comments.Sep 29 2021, 6:50 PM
libcxx/docs/TestingLibcxx.rst
230

But if the person wants to do testing or running the benchmark, it is certain that they have already built the libcxx and that build directory contains a generated CMake project. Sorry if I misunderstood your comment.

231

fine

xgupta updated this revision to Diff 376087.Sep 29 2021, 6:50 PM

address comment

ldionne accepted this revision.Oct 1 2021, 1:43 PM
This revision is now accepted and ready to land.Oct 1 2021, 1:43 PM
This revision was automatically updated to reflect the committed changes.