This is an archive of the discontinued LLVM Phabricator instance.

tsan: fix cur_thread alignment
ClosedPublic

Authored by dvyukov on Sep 28 2021, 7:48 AM.

Details

Summary

Commit 354ded67b3 ("tsan: align ThreadState to cache line")
did an incomplete thing. It marked ThreadState as cache line
aligned, but the thread local ThreadState instance is declared
as an aligned char array with hard-coded 64-byte alignment.
On PowerPC cache line size is 128 bytes, so the hard-coded
64-byte alignment is not enough.
Use cache line alignment consistently.

Diff Detail

Event Timeline

dvyukov created this revision.Sep 28 2021, 7:48 AM
dvyukov requested review of this revision.Sep 28 2021, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 28 2021, 7:48 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Sep 28 2021, 7:49 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

Thank you for fixing this.