Page MenuHomePhabricator

[X86][FP16] Fix a bug when Combine the FADD(A, FMA(B, C, 0)) to FMA(B, C, A).
ClosedPublic

Authored by LiuChen3 on Sep 27 2021, 6:42 PM.

Details

Summary

This bug was introduced by D109953. The operand order of generated FMA
is wrong.

Diff Detail

Event Timeline

LiuChen3 created this revision.Sep 27 2021, 6:42 PM
LiuChen3 requested review of this revision.Sep 27 2021, 6:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2021, 6:42 PM
pengfei accepted this revision.Sep 27 2021, 7:28 PM

My fault. I missed to change here. Thanks Chen! LGTM.

This revision is now accepted and ready to land.Sep 27 2021, 7:28 PM
FreddyYe accepted this revision.Sep 27 2021, 7:39 PM

LGTM.

LiuChen3 updated this revision to Diff 375462.Sep 27 2021, 8:14 PM

Fix check-all fail.

Can you take a review again and +1 if no problem? I missed changing some testcases. Thanks.

FreddyYe accepted this revision.Sep 27 2021, 8:22 PM

LGTM.

This revision was landed with ongoing or failed builds.Sep 27 2021, 8:39 PM
This revision was automatically updated to reflect the committed changes.

Thanks for you review.