Page MenuHomePhabricator

[lldb] Remove non-stop mode code
ClosedPublic

Authored by labath on Sep 27 2021, 8:00 AM.

Details

Summary

We added some support for this mode back in 2015, but the feature was
never productionized. It is completely untested, and there are known
major structural lldb issues that need to be resolved before this
feature can really be supported.

It also complicates making further changes to stop reply packet
handling, which is what I am about to do.

Diff Detail

Event Timeline

labath requested review of this revision.Sep 27 2021, 8:00 AM
labath created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 27 2021, 8:00 AM
jingham accepted this revision.Sep 27 2021, 12:11 PM

I don't think this patch added all that much value, and pretty much only worked if the non-stop threads never stopped... I think we'd have to start deeper in lldb to if we really want to support having threads that might stop while we think the process is stopped, and carrying this forward isn't going to help that effort when we get around to it.

So I have no problem with removing this.

This revision is now accepted and ready to land.Sep 27 2021, 12:11 PM
krytarowski accepted this revision.Sep 27 2021, 12:28 PM
krytarowski added a subscriber: krytarowski.

NetBSD and FreeBSD do not support non-stop in the kernel.

This revision was automatically updated to reflect the committed changes.