[libc++][format][6/6] Improve vformat.
Changes PlannedPublic
Actions

Authored by Mordante on Sep 26 2021, 8:08 AM.

Details

Reviewers

ldionne
vitaut

Group Reviewers

Restricted Project

Summary

Directly use the string's insert operation instead of using a
back_insert_iterator wrapper. With the other changes in this series the
back_insert_iterator will merely be a wrapper to select the strings
insert operation.

Depends on D110499

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Mordante requested review of this revision.Sep 26 2021, 8:08 AM

Mordante created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptSep 26 2021, 8:08 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Harbormaster completed remote builds in B125763: Diff 375111.Sep 26 2021, 8:09 AM

Needs to be updated due to the removal of __put in D110495.

Rebased and adjusted to changes in __put.

Harbormaster completed remote builds in B127945: Diff 378459.Oct 9 2021, 11:10 AM

Rebased to test with wchar_t changes.

Harbormaster completed remote builds in B129201: Diff 380198.Oct 16 2021, 11:48 AM

Mordante added a child revision: D112361: [libc++][format] Buffer changes proof-of-concept.Oct 23 2021, 4:41 AM

Mordante planned changes to this revision.Nov 2 2021, 10:58 AM

h-vetinari added a subscriber: h-vetinari.Mar 26 2022, 2:53 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2022, 2:53 PM

LGTM

vitaut added inline comments.Apr 1 2022, 3:38 PM

libcxx/include/format
553	Why pass a pointer rather than a reference (and take a pointer in the ctor)?

Revision Contents
Changeset List

Path

Size

libcxx/

include/

__format/

buffer.h

3 lines

format

30 lines

Diff 378459

View Options

libcxx/include/__format/buffer.h