[LLDB] Fix objc_clsopt_v16_t struct

[gAlfonso-bit]

Summary

The objc_clsopt_v16_t struct does not match up with the macOS/iOS15 dyld_shared_cache ObjC runtime structures. A struct field was seemingly omitted.

[bulbazord]

Unfortunately I'm probably not the right person for this. @JDevlieghere may be the right person, and if not, he can probably point you to the right people.

[pete]

I forgot that field in dyld. Its implicit due to the uint64_t salt, but no harm in having it here. I'm going to add it to dyld now too :)

[JDevlieghere]

Thanks Pete, LGTM

[gAlfonso-bit]

Any updates?

[JDevlieghere]

In D110477#3034393, @gAlfonso-bit wrote:

Any updates?

This patch is accepted and ready to land. Let me know if you don't have commit access and need someone to land this for you.

[gAlfonso-bit]

In D110477#3034438, @JDevlieghere wrote:

In D110477#3034393, @gAlfonso-bit wrote:

Any updates?

This patch is accepted and ready to land. Let me know if you don't have commit access and need someone to land this for you.

Unfortunately I do not have commit access

[JDevlieghere]

In D110477#3038298, @gAlfonso-bit wrote:

In D110477#3034438, @JDevlieghere wrote:

In D110477#3034393, @gAlfonso-bit wrote:

Any updates?

This patch is accepted and ready to land. Let me know if you don't have commit access and need someone to land this for you.

Unfortunately I do not have commit access

No worries, I've landed this patch for you. Next time don't hesitate to ask.

lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

 };
 
 struct objc_clsopt_v16_t {
    uint32_t version;
    uint32_t capacity;
    uint32_t occupied;
    uint32_t shift;
    uint32_t mask;
+   uint32_t zero;
    uint64_t salt;
    uint32_t scramble[256];
    uint8_t  tab[0]; // tab[mask+1]
    //  uint8_t checkbytes[capacity];
    //  int32_t offset[capacity];
    //  objc_classheader_t clsOffsets[capacity];
    //  uint32_t duplicateCount;
    //  objc_classheader_t duplicateOffsets[duplicateCount];