Page MenuHomePhabricator

[IR][NFC] Rename getBaseObject to getAliaseeObject
ClosedPublic

Authored by ibookstein on Fri, Sep 24, 3:58 AM.

Details

Summary

To better reflect the meaning of the now-disambiguated
{GlobalValue, GlobalAlias}::getBaseObject after breaking off
GlobalIFunc::getResolverFunction, the function is renamed to
getAliaseeObject.

Diff Detail

Unit TestsFailed

TimeTest
700 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-cxa-atexit.S
Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-cxa-atexit.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-cxa-atexit.S
700 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-static-initializer.S
Script: -- : 'RUN: at line 7'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-static-initializer.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-static-initializer.S
590 msx64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-tls.S
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -m64 -c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/orc/X86_64LinuxConfig/TestCases/Linux/x86-64/Output/trivial-tls.S.tmp /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/orc/TestCases/Linux/x86-64/trivial-tls.S

Event Timeline

ibookstein created this revision.Fri, Sep 24, 3:58 AM
ibookstein requested review of this revision.Fri, Sep 24, 3:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Sep 24, 3:58 AM

Renamed one additional straggler in clang, removed trailing whitespace elimination hunks.

MaskRay accepted this revision.Fri, Sep 24, 9:00 AM
This revision is now accepted and ready to land.Fri, Sep 24, 9:00 AM

Might I ask that you commit this on my behalf? Got no commit access :)
(I think the test failures are unrelated, they complain about missing file llvm-jitlink o_O)

Author: Itay Bookstein <ibookstein@gmail.com>

Will push next Monday

Sorry that I forgot to push this last Monday. I was then out of town for one week and was just back.

Pushed on your behalf. I checked some large users like Julia/Rust/Swift and many other downstream users and confirmed that none uses the API, so I don't consider adding a compatibility alias.

MaskRay closed this revision.Wed, Oct 6, 7:35 PM

Closed by 40ec1c0f16cb23f8b83fb3d28b195e83991defd9

Forgot to attach Differential Revision: