This is an archive of the discontinued LLVM Phabricator instance.

[profile][fuchsia] Don't include extra NUL in log messages
ClosedPublic

Authored by mcgrathr on Sep 23 2021, 1:37 PM.

Reviewers

Commits

	Time	Test
	50 ms	x64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-cxa-atexit.S
	50 ms	x64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-static-initializer.S
	60 ms	x64 debian > ORC-x86_64-linux.TestCases/Linux/x86-64::trivial-tls.S
	270 ms	x64 debian > Profile-x86_64.Linux::binary-id.c

mcgrathr requested review of this revision.Sep 23 2021, 1:37 PM

mcgrathr created this revision.

Herald added a subscriber: Restricted Project. · View Herald Transcript

LGTM

This revision is now accepted and ready to land.Sep 23 2021, 1:51 PM

This revision was landed with ongoing or failed builds.Sep 23 2021, 3:16 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

compiler-rt/

lib/

profile/

2 lines

	Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
	static inline void lprofWrite(const char *fmt, ...) {			static inline void lprofWrite(const char *fmt, ...) {
	char s[256];			char s[256];

	va_list ap;			va_list ap;
	va_start(ap, fmt);			va_start(ap, fmt);
	int ret = vsnprintf(s, sizeof(s), fmt, ap);			int ret = vsnprintf(s, sizeof(s), fmt, ap);
	va_end(ap);			va_end(ap);

	__sanitizer_log_write(s, ret + 1);			__sanitizer_log_write(s, ret);
	}			}

	struct lprofVMOWriterCtx {			struct lprofVMOWriterCtx {
	/* VMO that contains the profile data for this module. */			/* VMO that contains the profile data for this module. */
	zx_handle_t Vmo;			zx_handle_t Vmo;
	/* Current offset within the VMO where data should be written next. */			/* Current offset within the VMO where data should be written next. */
	uint64_t Offset;			uint64_t Offset;
	};			};
	▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines