This is an archive of the discontinued LLVM Phabricator instance.

[NFC][libcxxabi] In cxa_guard, switch away from an inheritance based design
AbandonedPublic

Authored by DanielMcIntosh-IBM on Sep 23 2021, 9:31 AM.

Details

Reviewers
ldionne
EricWF
nicholas
jroelofs
Group Reviewers
Restricted Project
Summary

This gets rid of the need for multiple inheritance, and better
reflects the design - a Guard isn't an instance of GuardByte or
InitByte, it merely uses them.

This is the 6th of 6 changes to overhaul cxa_guard.
See D108343 for what the final result will be and more details on why
cxa_guard is getting overhauled.

Depends on D110101

Diff Detail

Event Timeline

DanielMcIntosh-IBM requested review of this revision.Sep 23 2021, 9:31 AM
DanielMcIntosh-IBM created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2021, 9:31 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
DanielMcIntosh-IBM edited the summary of this revision. (Show Details)Sep 23 2021, 10:20 AM

Abandoning, since I no longer think this is the best way of grouping the changes. See D115367, D115368 and D115369 for a newer version that groups things a little better, but with the same end result.