Oh, the win failure (https://buildkite.com/llvm-project/premerge-checks/builds/57480#f7da3275-775a-4cf4-9624-d3539dd1f709) might actually be real. Windows doesn't allow deleting files that are still in use, and due to AV or similar, the file might still be in use for a bit even after the program completes.
Is it possible to use soft links instead of copies? It would still be good to clean up afterwards, but if the host won't allow that cleanup in some cases at least we aren't leaving a big file around.
Possible, but I didn't want to affect the operation of the tests. I don't believe there is any issue with being able to clean up, but I forgot about this patch while waiting for @thakis to confirm that the test failures he saw weren't actually due to this change. I can go ahead and commit this later today if he doesn't get back, and just watch the bots.
Softlinks don't work on Windows, that's why these tests use copies.
clang_f_opts.c sadly started flaking almost immediately after this went in: http://22.214.171.124/win/46115/step_7.txt
So I fear the Windows file system can't handle this patch as-is.
Maybe we can use rm -f and maybe that way the error isn't fatal even when deleting the file doesn't work, not sure.
It's my personal bot. It doesn't send email. IMHO the problem of how to make bots send emails hasn't been solved (they either send too much or too little), so I'm not pretending that it has been ;)
Sadly the test is still failing after the -f change: http://126.96.36.199/win/46139/step_7.txt
Maybe tacking on an || true helps?