This is an archive of the discontinued LLVM Phabricator instance.

Differential D110090

[ELF][test] Restore important part of ICF alignment test
ClosedPublic

Authored by andrewng on Sep 20 2021, 11:27 AM.

Details

Reviewers
MaskRay
phosek
Commits
rG05b130342143: [ELF][test] Restore important part of ICF alignment test
Summary

Restore the checking of addresses in ICF test which was testing the
behaviour of ICF with regards to different alignments of otherwise
identical sections. Also make the test more robust to layout changes.

Diff Detail

Event Timeline

andrewng created this revision.Sep 20 2021, 11:27 AM
Herald added a subscriber: emaste. · View Herald TranscriptSep 20 2021, 11:27 AM
andrewng requested review of this revision.Sep 20 2021, 11:27 AM
MaskRay accepted this revision.Sep 20 2021, 11:40 AM

LGTM. I usually use a [test] to indicate no code is changed.

This revision is now accepted and ready to land.Sep 20 2021, 11:40 AM
Harbormaster completed remote builds in B124719: Diff 373665.Sep 20 2021, 11:59 AM
andrewng retitled this revision from [LLD][ELF] Restore important part of ICF alignment test to [ELF][test] Restore important part of ICF alignment test.Sep 21 2021, 2:22 AM
andrewng updated this revision to Diff 373813.EditedSep 21 2021, 2:25 AM

Added comment to test as suggested off-line by @jhenderson.

Harbormaster completed remote builds in B124832: Diff 373813.Sep 21 2021, 2:58 AM
Closed by commit rG05b130342143: [ELF][test] Restore important part of ICF alignment test (authored by andrewng). · Explain WhySep 22 2021, 6:16 AM
This revision was automatically updated to reflect the committed changes.
andrewng added a commit: rG05b130342143: [ELF][test] Restore important part of ICF alignment test.
Herald added a project: Restricted Project. · View Herald TranscriptSep 22 2021, 6:16 AM

Revision Contents

PathSize
lld/
test/
ELF/
7 lines

Diff 374202

lld/test/ELF/icf7.s

# REQUIRES: x86 # REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
# RUN: ld.lld %t -o %t2 --icf=all --print-icf-sections | FileCheck %s # RUN: ld.lld %t -o %t2 --Ttext=220000 --icf=all --print-icf-sections | FileCheck %s
# RUN: llvm-objdump -t %t2 | FileCheck --check-prefix=ALIGN %s # RUN: llvm-objdump -t %t2 | FileCheck --check-prefix=ALIGN %s
# CHECK: selected section {{.*}}:(.text.f1) # CHECK: selected section {{.*}}:(.text.f1)
# CHECK: removing identical section {{.*}}:(.text.f2) # CHECK: removing identical section {{.*}}:(.text.f2)
# ALIGN: .text 0000000000000000 _start ## Check that the selected section has the higher alignment of the two identical sections.
# ALIGN: .text 0000000000000000 f1 # ALIGN: 0000000000220000 g .text 0000000000000000 _start
# ALIGN: 0000000000220100 g .text 0000000000000000 f1
.globl _start, f1, f2 .globl _start, f1, f2
_start: _start:
ret ret
.section .text.f1, "ax" .section .text.f1, "ax"
.align 1 .align 1
f1: f1:
Show All 10 Lines