This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add implementations of div, ldiv, lldiv and imaxdiv.
ClosedPublic

Authored by sivachandra on Sep 17 2021, 12:39 AM.

Diff Detail

Event Timeline

sivachandra created this revision.Sep 17 2021, 12:39 AM
sivachandra requested review of this revision.Sep 17 2021, 12:39 AM
sivachandra retitled this revision from [libc] Add implementation s of div, ldiv, lldiv and imaxdiv. to [libc] Add implementations of div, ldiv, lldiv and imaxdiv..Sep 17 2021, 12:44 AM
michaelrj accepted this revision.Sep 17 2021, 10:08 AM

LGTM with nits

libc/config/linux/aarch64/entrypoints.txt
171–175

this seems to be empty, so probably remove it, or at least the stdlib.h comment.

libc/src/inttypes/imaxdiv.h
9

should be LLVM_LIBC_SRC_INTTYPES_IMAXDIV_H

This revision is now accepted and ready to land.Sep 17 2021, 10:08 AM
sivachandra marked 2 inline comments as done.

Address comments

This revision was landed with ongoing or failed builds.Sep 19 2021, 9:51 PM
This revision was automatically updated to reflect the committed changes.