This is an archive of the discontinued LLVM Phabricator instance.

[test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c
ClosedPublic

Authored by ormris on Sep 15 2021, 2:54 PM.

Download Raw Diff

Details

Reviewers

cor3ntin
aaron.ballman

Commits

rG003fed8269b3: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c

Summary

Specify the C and C++ standards explicitly for this test. This avoids failures for drivers that default to older standards.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ormris requested review of this revision.Sep 15 2021, 2:54 PM

ormris created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptSep 15 2021, 2:54 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Thanks!

For which platforms did you had issue?
This is suppose to work in all language modes (we might want to use C99/C++98 to make sure that's the case)

Harbormaster completed remote builds in B124096: Diff 372812.Sep 15 2021, 3:27 PM

We saw this failure on our internal SIE (PlayStation) platform. I just tested on x86_64-unknown-linux-gnu using C99 and C++98, though, and the test fails. It looks like this feature is restricted to more recent standard versions somehow.

Okay, what's happening is that utf literals are only available for c++11 onward and the tests do not account for that.
Would you mind dropping the minimum version to C++11 and C11? I think that would be reasonable.

I could do a more extensive fix but I don't know how urgent this is for you

Downgrade to C11 and C++11

I think the test fix is all that's needed for now. This is somewhat urgent for us.

cor3ntin accepted this revision.Sep 15 2021, 5:26 PM

This revision is now accepted and ready to land.Sep 15 2021, 5:26 PM

Harbormaster completed remote builds in B124119: Diff 372839.Sep 15 2021, 5:35 PM

LGTM!

Closed by commit rG003fed8269b3: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c (authored by ormris). · Explain WhySep 16 2021, 9:20 AM

This revision was automatically updated to reflect the committed changes.

ormris added a commit: rG003fed8269b3: [test] Fix test failure in Clang :: Lexer/char-escapes-delimited.c.

Thanks for the review!

Revision Contents

Path

Size

clang/

test/

Lexer/

char-escapes-delimited.c

8 lines

Diff 372812

clang/test/Lexer/char-escapes-delimited.c

	// RUN: %clang_cc1 -fsyntax-only -pedantic -verify %s			// RUN: %clang_cc1 -x c++ -std=gnu++20 -fsyntax-only -pedantic -verify %s
	// RUN: %clang_cc1 -x c -fsyntax-only -pedantic -verify %s			// RUN: %clang_cc1 -x c -std=gnu2x -fsyntax-only -pedantic -verify %s
	// RUN: %clang_cc1 -fwchar-type=short -fno-signed-wchar -fsyntax-only -pedantic -verify %s			// RUN: %clang_cc1 -x c++ -std=gnu++20 -fwchar-type=short -fno-signed-wchar -fsyntax-only -pedantic -verify %s
	// RUN: %clang_cc1 -x c -fwchar-type=short -fno-signed-wchar -fsyntax-only -pedantic -verify %s			// RUN: %clang_cc1 -x c -std=gnu2x -fwchar-type=short -fno-signed-wchar -fsyntax-only -pedantic -verify %s

	const char *errors =			const char *errors =
	"\u{}" //expected-error {{delimited escape sequence cannot be empty}}			"\u{}" //expected-error {{delimited escape sequence cannot be empty}}
	"\u{" //expected-error {{expected '}'}}			"\u{" //expected-error {{expected '}'}}
	"\u{h}" //expected-error {{invalid digit 'h' in escape sequence}}			"\u{h}" //expected-error {{invalid digit 'h' in escape sequence}}
	"\x{}" //expected-error {{delimited escape sequence cannot be empty}}			"\x{}" //expected-error {{delimited escape sequence cannot be empty}}
	"\x{" //expected-error {{expected '}'}}			"\x{" //expected-error {{expected '}'}}
	"\x{h}" //expected-error {{invalid digit 'h' in escape sequence}}			"\x{h}" //expected-error {{invalid digit 'h' in escape sequence}}
	▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines