[LLDB] [Minidump] Fix format string warnings on Windows

[mstorsjo]

Summary

These variables are 'size_t' and thus should use %zu. On Windows,
'long' is always 32 bit.

[bulbazord]

Adding MaskRay who fixed something similar to this yesterday.

[mstorsjo]

Oh, sorry, I worked on a checkout a couple weeks old, where I ran into this warning. It does indeed seem to be fixed in the current git main branch.

[MaskRay]

I fixed this in e69d359841b6358f1d17569212ef8cf91244ca11 and fixed some style issues.

---

This needs extra care.

While Clang -Wformat flags

printf("%llu", (size_t)3);

warning: format specifies type 'unsigned long long' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat]

This is silent:

printf("%ld", (size_t)3);

lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp

Status MinidumpFileBuilder::Dump(lldb::FileUP &core_file) const {
   Status error;
   size_t bytes_written;
 
   bytes_written = header_size;
   error = core_file->Write(&header, bytes_written);
   if (error.Fail() || bytes_written != header_size) {
     if (bytes_written != header_size)
       error.SetErrorStringWithFormat(
-          "Unable to write the header. (written %ld/%ld).", bytes_written,
+          "Unable to write the header. (written %zd/%zd).", bytes_written,
           header_size);
     return error;
   }
 
   // write data
   bytes_written = m_data.GetByteSize();
   error = core_file->Write(m_data.GetBytes(), bytes_written);
   if (error.Fail() || bytes_written != m_data.GetByteSize()) {
     if (bytes_written != m_data.GetByteSize())
       error.SetErrorStringWithFormat(
-          "Unable to write the data. (written %ld/%ld).", bytes_written,
+          "Unable to write the data. (written %zd/%zd).", bytes_written,
           m_data.GetByteSize());
     return error;
   }
 
   // write directories
   for (const Directory &dir : m_directories) {
     bytes_written = directory_size;
     error = core_file->Write(&dir, bytes_written);
     if (error.Fail() || bytes_written != directory_size) {
       if (bytes_written != directory_size)
         error.SetErrorStringWithFormat(
-            "Unable to write the directory. (written %ld/%ld).", bytes_written,
+            "Unable to write the directory. (written %zd/%zd).", bytes_written,
             directory_size);
       return error;
     }
   }
 
   return error;
 }
 
 size_t MinidumpFileBuilder::GetDirectoriesNum() const {
   return m_directories.size();
 }
 
 size_t MinidumpFileBuilder::GetCurrentDataEndOffset() const {
   return sizeof(llvm::minidump::Header) + m_data.GetByteSize();
 }
 No newline at end of file