This is an archive of the discontinued LLVM Phabricator instance.

Differential D109655

[BitcodeReader] fix a logic error in vector type element validation
ClosedPublic

Authored by woodruffw on Sep 11 2021, 11:51 PM.

Details

Reviewers
pcc
xgupta
Commits
rG778bf73d7ba6: [BitcodeReader] fix a logic error in vector type element validation
Summary

The current code checks whether the vector's element type is a valid structure element type, rather than a valid vector element type. The two have separate implementations and but only accept very slightly different sets of types, which is probably why this wasn't caught before.

Diff Detail

Event Timeline

woodruffw created this revision.Sep 11 2021, 11:51 PM
Herald added a subscriber: hiraditya. · View Herald TranscriptSep 11 2021, 11:51 PM
woodruffw requested review of this revision.Sep 11 2021, 11:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 11 2021, 11:51 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B123580: Diff 372106.Sep 12 2021, 12:28 AM
woodruffw updated this revision to Diff 372593.Sep 14 2021, 5:13 PM

Increase the context for the patch.

Harbormaster completed remote builds in B123928: Diff 372593.Sep 14 2021, 5:47 PM
woodruffw added a comment.Oct 3 2021, 7:53 PM

Gentle ping for review.

xgupta accepted this revision.Oct 8 2021, 8:31 PM
xgupta added a subscriber: xgupta.

LGTM, Thanks.

This revision is now accepted and ready to land.Oct 8 2021, 8:31 PM
woodruffw added a comment.Oct 8 2021, 8:46 PM

Thanks! I don't have commit access so I'll need someone else to do the merge :-)

xgupta added a comment.Oct 8 2021, 8:47 PM

just doing after a check-llvm.

This revision was landed with ongoing or failed builds.Oct 8 2021, 9:12 PM
Closed by commit rG778bf73d7ba6: [BitcodeReader] fix a logic error in vector type element validation (authored by woodruffw, committed by xgupta). · Explain Why
This revision was automatically updated to reflect the committed changes.
xgupta added a commit: rG778bf73d7ba6: [BitcodeReader] fix a logic error in vector type element validation.

Revision Contents

PathSize
llvm/
lib/
Bitcode/
Reader/
2 lines

Diff 372106

llvm/lib/Bitcode/Reader/BitcodeReader.cpp

Context not available.
if (Record[0] == 0) if (Record[0] == 0)
return error("Invalid vector length"); return error("Invalid vector length");
ResultTy = getTypeByID(Record[1]); ResultTy = getTypeByID(Record[1]);
if (!ResultTy || !StructType::isValidElementType(ResultTy)) if (!ResultTy || !VectorType::isValidElementType(ResultTy))
return error("Invalid type"); return error("Invalid type");
bool Scalable = Record.size() > 2 ? Record[2] : false; bool Scalable = Record.size() > 2 ? Record[2] : false;
ResultTy = VectorType::get(ResultTy, Record[0], Scalable); ResultTy = VectorType::get(ResultTy, Record[0], Scalable);
Context not available.