Page MenuHomePhabricator

[BitcodeReader] fix a logic error in vector type element validation
Needs ReviewPublic

Authored by woodruffw on Sat, Sep 11, 11:51 PM.

Details

Reviewers
pcc
Summary

The current code checks whether the vector's element type is a valid structure element type, rather than a valid vector element type. The two have separate implementations and but only accept very slightly different sets of types, which is probably why this wasn't caught before.

Diff Detail

Unit TestsFailed

TimeTest
250 msx64 windows > Clang Tools.clang-tidy/checkers::readability-container-data-pointer.cpp
Script: -- : 'RUN: at line 1'; C:/Python39/python.exe C:/ws/w8/llvm-project/premerge-checks/clang-tools-extra/test/../test\clang-tidy\check_clang_tidy.py C:\ws\w8\llvm-project\premerge-checks\clang-tools-extra\test\clang-tidy\checkers\readability-container-data-pointer.cpp readability-container-data-pointer C:\ws\w8\llvm-project\premerge-checks\build\tools\clang\tools\extra\test\clang-tidy\checkers\Output\readability-container-data-pointer.cpp.tmp

Event Timeline

woodruffw created this revision.Sat, Sep 11, 11:51 PM
woodruffw requested review of this revision.Sat, Sep 11, 11:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Sep 11, 11:51 PM
woodruffw updated this revision to Diff 372593.Tue, Sep 14, 5:13 PM

Increase the context for the patch.