Fix definitions in AVR target for MCUs xmega16a4u and xmega128a4u to match avr-libc.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I guess this would have qualified for post-commit review, but since this would have been my first commit I made myself, I want to be careful ^^
Comments on this would be nice, if this would have been ok to just commit.
Comment Actions
This is committed by now, but I would still love to know if this would have been ok to just commit (and have post-commit review) :)
Comment Actions
Yeah, Such patches are OK to commit by just adding a [NFC] tag in commit message. Though if you spend some time on Phabricator, you will be aware of which kind of patches need reviews and which can be committed directly.