Page MenuHomePhabricator

Fix some definitions on AVR target
ClosedPublic

Authored by LittleFox94 on Sep 11 2021, 3:06 PM.

Details

Summary

Fix definitions in AVR target for MCUs xmega16a4u and xmega128a4u to match avr-libc.

Diff Detail

Event Timeline

LittleFox94 created this revision.Sep 11 2021, 3:06 PM
LittleFox94 requested review of this revision.Sep 11 2021, 3:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 11 2021, 3:06 PM

I guess this would have qualified for post-commit review, but since this would have been my first commit I made myself, I want to be careful ^^
Comments on this would be nice, if this would have been ok to just commit.

This revision is now accepted and ready to land.Sep 11 2021, 10:25 PM
This revision was automatically updated to reflect the committed changes.

This is committed by now, but I would still love to know if this would have been ok to just commit (and have post-commit review) :)

Yeah, Such patches are OK to commit by just adding a [NFC] tag in commit message. Though if you spend some time on Phabricator, you will be aware of which kind of patches need reviews and which can be committed directly.