This is an archive of the discontinued LLVM Phabricator instance.

[LNT] Fixed relative addresses parsing in ASM code
ClosedPublic

Authored by kpdev42 on Sep 10 2021, 1:05 AM.

Details

Summary

Fixed relative addresses parsing in ASM code for Control Flow Graph on the Profile page

Diff Detail

Repository
rLNT LNT

Event Timeline

kpdev42 created this revision.Sep 10 2021, 1:05 AM
kpdev42 requested review of this revision.Sep 10 2021, 1:05 AM
thopre added inline comments.Sep 10 2021, 1:49 AM
lnt/server/ui/static/lnt_profile.js
135–136

Might be worth updating the comment to explain the format it accepts for addressString

kpdev42 added inline comments.Sep 10 2021, 4:19 AM
lnt/server/ui/static/lnt_profile.js
135–136

Will do, thank you!

kpdev42 updated this revision to Diff 371878.Sep 10 2021, 4:45 AM

Updated comment with to explain format of parsed address

thopre accepted this revision.Sep 10 2021, 4:52 AM

LGTM

This revision is now accepted and ready to land.Sep 10 2021, 4:52 AM
This revision was landed with ongoing or failed builds.Sep 10 2021, 8:15 AM
This revision was automatically updated to reflect the committed changes.