This is an archive of the discontinued LLVM Phabricator instance.

Increase expected line number for ExtDebugInfo.cpp
ClosedPublic

Authored by Jake-Egan on Sep 9 2021, 1:30 PM.

Details

Summary

This patch increases the expected line number for one of the checks so that it doesn't have to be updated for any added/removed lines in the RUN section.

This change is in preparation for the following patch: https://reviews.llvm.org/D109060

Diff Detail

Event Timeline

Jake-Egan requested review of this revision.Sep 9 2021, 1:30 PM
Jake-Egan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 9 2021, 1:30 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Jake-Egan edited the summary of this revision. (Show Details)Sep 9 2021, 1:38 PM
Jake-Egan added a reviewer: jsji.
jsji accepted this revision.Sep 9 2021, 7:41 PM
jsji added a reviewer: aprantl.

LGTM. But please wait to see whether @aprantl has any comments. Thanks.

clang/test/Modules/ExtDebugInfo.cpp
27

Add comment about why we want to add this directive here.

This revision is now accepted and ready to land.Sep 9 2021, 7:43 PM
Jake-Egan updated this revision to Diff 371908.Sep 10 2021, 6:20 AM

Added a comment.

Jake-Egan marked an inline comment as done.Sep 10 2021, 6:20 AM
This revision was landed with ongoing or failed builds.Sep 16 2021, 7:06 AM
This revision was automatically updated to reflect the committed changes.