[OptParser] NFC: Remove unused template arg 'name' from bool opt

[c-rhodes]

Summary

Identified in D109359.

[c-rhodes]

@jansvoboda11 this came up in D109359 with warning:

llvm/include/llvm/Option/OptParser.td:217:91: warning: unused template argument: MarshallingInfoBooleanFlag:name

I see you've changed worked on this in the past, wasn't sure if it's intended for name not to be used so thought I'd post the patch and let you take a look.

[jansvoboda11]

LGTM.

To give more background, I think my intention was to add an assertion that name and other_name are the same (except for the no_ part) and I was waiting for TableGen assertions to land. But I don't think that's too valuable, since the callers already ensure that by some other mechanism. This should be fine to remove.

[c-rhodes]

In D109489#2991261, @jansvoboda11 wrote:

LGTM.

To give more background, I think my intention was to add an assertion that name and other_name are the same (except for the no_ part) and I was waiting for TableGen assertions to land. But I don't think that's too valuable, since the callers already ensure that by some other mechanism. This should be fine to remove.

No worries thanks for clarifying!

clang/include/clang/Driver/Options.td

 }
 
 // TableGen record for a single marshalled flag.
 class MarshalledFlagRec<FlagDefExpanded flag, FlagDefExpanded other,
                         FlagDefExpanded implied, KeyPathAndMacro kpm,
                         Default default>
   : Flag<["-"], flag.Spelling>, Flags<flag.OptionFlags>, HelpText<flag.Help>,
     MarshallingInfoBooleanFlag<kpm, default.Value, flag.ValueAsCode,
-                               flag.RecordName, other.ValueAsCode,
-                               other.RecordName>,
+                               other.ValueAsCode, other.RecordName>,
     ImpliedByAnyOf<implied.ImpliedBy, implied.ValueAsCode> {}
 
 // Generates TableGen records for two command line flags that control the same
 // key path via the marshalling infrastructure.
 // Names of the records consist of the specified prefix, "no_" for the negative
 // flag, and NAME.
 // Used for -cc1 frontend options. Driver-only options do not map to
 // CompilerInvocation.

llvm/include/llvm/Option/OptParser.td

 class MarshallingInfoBitfieldFlag<KeyPathAndMacro kpm, code value>
   : MarshallingInfoFlag<kpm, "0u"> {
   code Normalizer = "makeFlagToValueNormalizer("#value#")";
   code ValueMerger = "mergeMaskValue";
   code ValueExtractor = "(extractMaskValue<unsigned, decltype("#value#"), "#value#">)";
 }
 
 // Implementation detail of BoolOption.
-class MarshallingInfoBooleanFlag<KeyPathAndMacro kpm, code defaultvalue, code value, code name,
+class MarshallingInfoBooleanFlag<KeyPathAndMacro kpm, code defaultvalue, code value,
                                  code other_value, code other_name>
   : MarshallingInfoFlag<kpm, defaultvalue> {
   code Normalizer = "makeBooleanOptionNormalizer("#value#", "#other_value#", OPT_"#other_name#")";
   code Denormalizer = "makeBooleanOptionDenormalizer("#value#")";
 }
 
 // Marshalled option accepting any of the specified enum values.
 // Typically used with `Values`, `NormalizedValues` and `NormalizedValuesScope`.