This is an archive of the discontinued LLVM Phabricator instance.

Differential D109292

[RuntimeDyld] Don't use bitwise operation on SymbolRef::Type
ClosedPublic

Authored by StephenFan on Sep 5 2021, 8:49 AM.

Details

Reviewers
lhames
Commits
rGffcaa80f7e43: [RuntimeDyld] Don't use bitwise operation on SymbolRef::Type

Diff Detail

Revision Contents

PathSize
llvm/
lib/
ExecutionEngine/
RuntimeDyld/
2 lines

Diff 371009

llvm/lib/ExecutionEngine/RuntimeDyld/JITSymbol.cpp

Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Lines if (*SymbolFlagsOrErr & object::BasicSymbolRef::SF_Common)
Flags |= JITSymbolFlags::Common; Flags |= JITSymbolFlags::Common;
if (*SymbolFlagsOrErr & object::BasicSymbolRef::SF_Exported) if (*SymbolFlagsOrErr & object::BasicSymbolRef::SF_Exported)
Flags |= JITSymbolFlags::Exported; Flags |= JITSymbolFlags::Exported;
auto SymbolType = Symbol.getType(); auto SymbolType = Symbol.getType();
if (!SymbolType) if (!SymbolType)
return SymbolType.takeError(); return SymbolType.takeError();
if (*SymbolType & object::SymbolRef::ST_Function) if (*SymbolType == object::SymbolRef::ST_Function)
Flags |= JITSymbolFlags::Callable; Flags |= JITSymbolFlags::Callable;
return Flags; return Flags;
} }
ARMJITSymbolFlags ARMJITSymbolFlags
llvm::ARMJITSymbolFlags::fromObjectSymbol(const object::SymbolRef &Symbol) { llvm::ARMJITSymbolFlags::fromObjectSymbol(const object::SymbolRef &Symbol) {
Expected<uint32_t> SymbolFlagsOrErr = Symbol.getFlags(); Expected<uint32_t> SymbolFlagsOrErr = Symbol.getFlags();
▲ Show 20 Lines • Show All 74 Lines • Show Last 20 Lines