This is an archive of the discontinued LLVM Phabricator instance.

Differential D109266

[OpenMP] libomptarget build fix proposal
AbandonedPublic

Authored by devnexen on Sep 3 2021, 9:32 PM.

Details

Reviewers
ye-luo
jdoerfert
Summary

build fails due to the unique_ptr member.

Diff Detail

Event Timeline

devnexen created this revision.Sep 3 2021, 9:32 PM
Herald added subscribers: guansong, yaxunl. · View Herald TranscriptSep 3 2021, 9:32 PM
devnexen requested review of this revision.Sep 3 2021, 9:32 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptSep 3 2021, 9:32 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
devnexen abandoned this revision.Sep 3 2021, 9:33 PM
Harbormaster completed remote builds in B122603: Diff 370696.Sep 3 2021, 10:04 PM

Revision Contents

PathSize
openmp/
libomptarget/
src/
5 lines

Diff 370696

openmp/libomptarget/src/device.cpp

Show All 27 Lines : DeviceID(D.DeviceID), RTL(D.RTL), RTLDeviceID(D.RTLDeviceID),
LoopTripCnt(D.LoopTripCnt) {} LoopTripCnt(D.LoopTripCnt) {}
DeviceTy &DeviceTy::operator=(const DeviceTy &D) { DeviceTy &DeviceTy::operator=(const DeviceTy &D) {
DeviceID = D.DeviceID; DeviceID = D.DeviceID;
RTL = D.RTL; RTL = D.RTL;
RTLDeviceID = D.RTLDeviceID; RTLDeviceID = D.RTLDeviceID;
IsInit = D.IsInit; IsInit = D.IsInit;
HasPendingGlobals = D.HasPendingGlobals; HasPendingGlobals = D.HasPendingGlobals;
HostDataToTargetMap = D.HostDataToTargetMap;
PendingCtorsDtors = D.PendingCtorsDtors; PendingCtorsDtors = D.PendingCtorsDtors;
ShadowPtrMap = D.ShadowPtrMap; ShadowPtrMap = D.ShadowPtrMap;
LoopTripCnt = D.LoopTripCnt; LoopTripCnt = D.LoopTripCnt;
HostDataToTargetMap.clear();
for (auto hostData: D.HostDataToTargetMap)
Lint: Pre-merge checks
Inline Actions

clang-tidy: warning: invalid case style for variable 'hostData' [readability-identifier-naming]
not useful
clang-format: please reformat the code

-  for (auto hostData: D.HostDataToTargetMap)
-	  HostDataToTargetMap.insert(hostData);
+  for (auto hostData : D.HostDataToTargetMap)
+    HostDataToTargetMap.insert(hostData);
Lint: Pre-merge checks: clang-tidy: warning: invalid case style for variable 'hostData' [readability-identifier-naming]…
HostDataToTargetMap.insert(hostData);
return *this; return *this;
} }
DeviceTy::DeviceTy(RTLInfoTy *RTL) DeviceTy::DeviceTy(RTLInfoTy *RTL)
: DeviceID(-1), RTL(RTL), RTLDeviceID(-1), IsInit(false), InitFlag(), : DeviceID(-1), RTL(RTL), RTLDeviceID(-1), IsInit(false), InitFlag(),
HasPendingGlobals(false), HostDataToTargetMap(), PendingCtorsDtors(), HasPendingGlobals(false), HostDataToTargetMap(), PendingCtorsDtors(),
ShadowPtrMap(), DataMapMtx(), PendingGlobalsMtx(), ShadowMtx() {} ShadowPtrMap(), DataMapMtx(), PendingGlobalsMtx(), ShadowMtx() {}
▲ Show 20 Lines • Show All 588 Lines • Show Last 20 Lines