This is an archive of the discontinued LLVM Phabricator instance.

[SCEV] Further clarify comments regarding UB and zero stride
ClosedPublic

Authored by reames on Sep 1 2021, 2:10 PM.

Details

Summary

Follow on to D109029. I realized we had no mention of mustprogrress in the comment (as it prexisted mustprogress in the codebase). In the process of adding it, I tweaked the preconditions into something I think is more clear. Note that mustprogress is checked in the code.

Diff Detail

Event Timeline

reames created this revision.Sep 1 2021, 2:10 PM
reames requested review of this revision.Sep 1 2021, 2:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2021, 2:10 PM
nikic edited reviewers, added: efriedma; removed: eli.friedman.Sep 1 2021, 2:12 PM
This revision is now accepted and ready to land.Sep 7 2021, 11:43 AM
This revision was landed with ongoing or failed builds.Sep 7 2021, 1:55 PM
This revision was automatically updated to reflect the committed changes.