This is an archive of the discontinued LLVM Phabricator instance.

[AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support
ClosedPublic

Authored by Jake-Egan on Sep 1 2021, 6:25 AM.

Details

Summary

AIX and z/OS lack Objective-C support, so mark these tests as unsupported for AIX and z/OS.

Diff Detail

Event Timeline

Jake-Egan requested review of this revision.Sep 1 2021, 6:25 AM
Jake-Egan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2021, 6:25 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
jsji added a subscriber: jsji.Sep 1 2021, 6:32 AM

For clang/test/CodeGenObjCXX and clang/test/CodeGenObjC, can we add lit.local.cfg and add the unsupport there, no adding to every files in the folder?

Jake-Egan retitled this revision from Disable LIT tests on AIX due to lack of Objective-C support to [AIX] Disable LIT tests on AIX due to lack of Objective-C support.Sep 1 2021, 6:38 AM
Jake-Egan edited the summary of this revision. (Show Details)
Jake-Egan added a comment.EditedSep 1 2021, 6:44 AM

For clang/test/CodeGenObjCXX and clang/test/CodeGenObjC, can we add lit.local.cfg and add the unsupport there, no adding to every files in the folder?

These tests are a subset of clang/test/CodeGenObjCXX and clang/test/CodeGenObjC. The rest of the tests in those folders are supported (cross-compiling).

jsji added a comment.Sep 1 2021, 7:09 AM

For clang/test/CodeGenObjCXX and clang/test/CodeGenObjC, can we add lit.local.cfg and add the unsupport there, no adding to every files in the folder?

These tests are a subset of clang/test/CodeGenObjCXX and clang/test/CodeGenObjC. The rest of the tests in those folders are supported (cross-compiling).

We don't have Objective-C support, so any passing tests are just somehow a luck, and I don't think it is meaningful to even run those tests.

jsji added a reviewer: Restricted Project.Sep 1 2021, 7:15 AM
Jake-Egan updated this revision to Diff 371137.Sep 7 2021, 11:40 AM
Jake-Egan edited the summary of this revision. (Show Details)

Added lit.local.cfg and unsupported z/OS as well.

Jake-Egan retitled this revision from [AIX] Disable LIT tests on AIX due to lack of Objective-C support to [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support.Sep 7 2021, 11:43 AM
Jake-Egan edited the summary of this revision. (Show Details)
jsji accepted this revision as: jsji.Sep 7 2021, 12:57 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Sep 7 2021, 12:57 PM
Jake-Egan updated this revision to Diff 371165.Sep 7 2021, 1:14 PM

Fixed ExtDebugInfo.cpp

jsji added inline comments.Sep 7 2021, 2:17 PM
clang/test/Modules/ExtDebugInfo.cpp
209

Why this change? If this is needed, this should be in another patch. Thanks.

Jake-Egan added inline comments.Sep 8 2021, 6:19 AM
clang/test/Modules/ExtDebugInfo.cpp
209

The test failed in Debian and Windows because the unsupported line I added changed the expected line number: 27->28.
https://reviews.llvm.org/D109060?id=371137

Without this change, this patch would cause a regression. But, I can put it in another patch if that's preferred.

jsji added inline comments.Sep 8 2021, 6:30 AM
clang/test/Modules/ExtDebugInfo.cpp
209

In that case, I would recommend we update it to regex match instead of hardcoding line no, and yes, in another patch before this.

Jake-Egan updated this revision to Diff 372946.Sep 16 2021, 7:44 AM

Revert last ExtDebugInfo.cpp change because https://reviews.llvm.org/rG45a738363ee39754a0e93d9f779bda2cad83fa18 has been committed.

Jake-Egan marked 2 inline comments as done.Sep 16 2021, 7:45 AM

Added missing tests:
clang/test/Modules/ModuleDebugInfoDwoId.cpp
clang/test/PCH/externally-retained.m
clang/test/PCH/pending-ids.m