AIX and z/OS lack Objective-C support, so mark these tests as unsupported for AIX and z/OS.
Details
- Reviewers
jsji - Group Reviewers
Restricted Project - Commits
- rG22f01cd4fc5d: [AIX][ZOS] Disable LIT tests on AIX and z/OS due to lack of Objective-C support
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
For clang/test/CodeGenObjCXX and clang/test/CodeGenObjC, can we add lit.local.cfg and add the unsupport there, no adding to every files in the folder?
These tests are a subset of clang/test/CodeGenObjCXX and clang/test/CodeGenObjC. The rest of the tests in those folders are supported (cross-compiling).
We don't have Objective-C support, so any passing tests are just somehow a luck, and I don't think it is meaningful to even run those tests.
clang/test/Modules/ExtDebugInfo.cpp | ||
---|---|---|
209 | Why this change? If this is needed, this should be in another patch. Thanks. |
clang/test/Modules/ExtDebugInfo.cpp | ||
---|---|---|
209 | The test failed in Debian and Windows because the unsupported line I added changed the expected line number: 27->28. Without this change, this patch would cause a regression. But, I can put it in another patch if that's preferred. |
clang/test/Modules/ExtDebugInfo.cpp | ||
---|---|---|
209 | In that case, I would recommend we update it to regex match instead of hardcoding line no, and yes, in another patch before this. |
Revert last ExtDebugInfo.cpp change because https://reviews.llvm.org/rG45a738363ee39754a0e93d9f779bda2cad83fa18 has been committed.
Added missing tests:
clang/test/Modules/ModuleDebugInfoDwoId.cpp
clang/test/PCH/externally-retained.m
clang/test/PCH/pending-ids.m
Why this change? If this is needed, this should be in another patch. Thanks.