This is an archive of the discontinued LLVM Phabricator instance.

Reworked the test part of r241149 "Fix PR23872: Integrated assembler error message when using .type directive with @ in AArch32 assembly."
ClosedPublic

Authored by enefaim on Jul 2 2015, 7:41 AM.

Details

Summary

The test part of r241149 has been reverted in r241451, due to misplaced test cases.
This patch splits those test cases among the appropriate targets.

Differential revision of r241149: http://reviews.llvm.org/D10651

Diff Detail

Repository
rL LLVM

Event Timeline

enefaim updated this revision to Diff 28944.Jul 2 2015, 7:41 AM
enefaim retitled this revision from to Reworked the test part of r241149 "Fix PR23872: Integrated assembler error message when using .type directive with @ in AArch32 assembly.".
enefaim updated this object.
enefaim set the repository for this revision to rL LLVM.
enefaim added a subscriber: llvm-commits.
rengolin edited edge metadata.Jul 2 2015, 7:59 AM

Hi Gabor,

Is ARM always enabled for COFF?

If not, we better create a directory in there, like the others.

--renato

enefaim updated this revision to Diff 28953.Jul 2 2015, 9:11 AM
enefaim edited edge metadata.

Changes in this version:

  • Created ARM subdirectory in test/MC/COFF
  • Moved directive-type-diagnostics.s from test/MC/COFF to test/MC/COFF/ARM

Also, please copy test/MC/ARM/lit.local.cfg (as is) into the new directory, so that only compilers with ARM support will run those tests.

enefaim updated this revision to Diff 28958.Jul 2 2015, 9:42 AM

Hi Renato,

Thanks for the review!

Changes in this version:

  • Added lit.local.cfg to the test/MC/COFF/ARM
rengolin accepted this revision.Jul 2 2015, 9:46 AM
rengolin edited edge metadata.

LGTM, Thanks!

This revision is now accepted and ready to land.Jul 2 2015, 9:46 AM
This revision was automatically updated to reflect the committed changes.

Apologies for the "miss" in the original review gents.