This is an archive of the discontinued LLVM Phabricator instance.

Differential D108970

[Docs][Phabricator] Mention how to create a draft revision
ClosedPublic

Authored by xgupta on Aug 30 2021, 10:56 PM.

Details

Reviewers
MaskRay
dblaikie
Commits
rG8254f4afcbca: [Docs][Phabricator] Mention how to create a draft revision
Summary

https://llvm.org/docs/Phabricator.html have two links to Arcnist guide but
none of them mention how to create a draft revision. It would create some less noise if
developers create draft revisoin in this(--draft) way instead of [WIP] tag way.

Diff Detail

Event Timeline

xgupta requested review of this revision.Aug 30 2021, 10:56 PM
xgupta created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2021, 10:56 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
xgupta mentioned this in D108700: do not merge, just a demo.Aug 30 2021, 10:59 PM
dblaikie accepted this revision.Aug 30 2021, 11:02 PM

Looks good, thanks! (just a few grammatical/spelling fixes)

llvm/docs/Phabricator.rst
51

typo/spelling for "experimental"

52
53
54
This revision is now accepted and ready to land.Aug 30 2021, 11:02 PM
xgupta updated this revision to Diff 369631.Aug 30 2021, 11:11 PM

fix grammatical mistakes

xgupta added a comment.Aug 30 2021, 11:12 PM
In D108970#2973995, @dblaikie wrote:

Looks good, thanks! (just a few grammatical/spelling fixes)

Thanks, I will take care to run a spellchecker from next time.

This revision was landed with ongoing or failed builds.Aug 30 2021, 11:13 PM
Closed by commit rG8254f4afcbca: [Docs][Phabricator] Mention how to create a draft revision (authored by xgupta). · Explain Why
This revision was automatically updated to reflect the committed changes.
xgupta added a commit: rG8254f4afcbca: [Docs][Phabricator] Mention how to create a draft revision.
Harbormaster completed remote builds in B121887: Diff 369631.Aug 30 2021, 11:45 PM

Revision Contents

PathSize
llvm/
docs/
12 lines

Diff 369632

llvm/docs/Phabricator.rst

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
The basic way of creating a revision for the current commit in your local The basic way of creating a revision for the current commit in your local
repository is to run: repository is to run:
:: ::
arc diff HEAD~ arc diff HEAD~
Sometime you may want to create a draft revision to show the proof of concept
or for experimental purposes, In that case you can use the `--draft` option. It
dblaikieUnsubmitted
Not Done
ReplyInline Actions
Sometime you may want to create a draft revision to show the proof of concept
- or for experiemntal purpose, In that case you can use the `--draft` option. It
+ or for experimental purposes. In that case you can use the `--draft` option. It
will either create a new draft revisoin or convert the original revision to

typo/spelling for "experimental"

dblaikie: typo/spelling for "experimental"
will either create a new draft revisoin or convert the original revision to a
dblaikieUnsubmitted
Not Done
ReplyInline Actions
or for experiemntal purpose, In that case you can use the `--draft` option. It
- will either create a new draft revisoin or convert the original revision to
+ will either create a new draft revisoin or convert the original revision to a
draft revision depending on your local branch status. Good part is: it will not
dblaikie:
draft revision depending on your local branch status. The good part is: it will not
dblaikieUnsubmitted
Not Done
ReplyInline Actions
will either create a new draft revisoin or convert the original revision to
- draft revision depending on your local branch status. Good part is: it will not
+ draft revision depending on your local branch status. The good part is: it will not
send mail to llvm-commit mailing list, patch reviewers and all other subscribers,
dblaikie:
send mail to llvm-commit mailing list, patch reviewers, and all other subscribers,
dblaikieUnsubmitted
Not Done
ReplyInline Actions
draft revision depending on your local branch status. Good part is: it will not
- send mail to llvm-commit mailing list, patch reviewers and all other subscribers,
+ send mail to llvm-commit mailing list, patch reviewers, and all other subscribers,
buildbot will also run on every patch update:
dblaikie:
buildbot will also run on every patch update:
::
arc diff --draft HEAD~
If you later update your commit message, you need to add the `--verbatim` If you later update your commit message, you need to add the `--verbatim`
option to have `arc` update the description on Phabricator: option to have `arc` update the description on Phabricator:
:: ::
arc diff --edit --verbatim arc diff --edit --verbatim
▲ Show 20 Lines • Show All 253 Lines • Show Last 20 Lines