Page MenuHomePhabricator

[docs] [NFC] Clarify the datalayout documentation
Needs ReviewPublic

Authored by woodruffw on Mon, Aug 30, 6:07 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This patch fixes a couple of small oversights in the documentation for the datalayout specification:

  • The v and f specifications are subject to the same constraints on <size> as i is.
  • The p[n] specification didn't mark <idx> as optional, despite being documented and parsed as such.
  • Similarly, none of the alignment specifications require <pref>.

Diff Detail

Event Timeline

woodruffw created this revision.Mon, Aug 30, 6:07 PM
woodruffw requested review of this revision.Mon, Aug 30, 6:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Aug 30, 6:07 PM
woodruffw updated this revision to Diff 369616.Mon, Aug 30, 8:39 PM
woodruffw edited the summary of this revision. (Show Details)

Also clarify that <pref> is optional in pointer alignment specifications.

woodruffw updated this revision to Diff 369618.Mon, Aug 30, 8:53 PM
woodruffw edited the summary of this revision. (Show Details)

Mark <pref> as optional in all of the alignment specs, since the DataLayout parser treats it as optional.

Ping for review on this.

Another gentle ping for review.