This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][docs] Remove completed issues from TODO.TXT
ClosedPublic

Authored by jloser on Aug 27 2021, 8:48 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG2498f8fd76c2: [libcxx][docs] Remove completed issues from TODO.TXT
Summary

Remove tasks listed that refer to papers or issues that are marked complete in
libcxx/docs/Status/Cxx17Papers.csv or libcxx/docs/Status/Cxx17Issues.csv

Diff Detail

Event Timeline

jloser requested review of this revision.Aug 27 2021, 8:48 PM
jloser created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2021, 8:48 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

FWIW, I'm OK with this. (Does anyone care about TODO.TXT anyway?) I spot-checked some of the removals (US 25, US 60, US 185 rejected, Late 36, Late 37) and found that libc++ implemented them correctly AFAICT.
@ldionne should be the sole arbiter here.

IMO we should remove this file, if there's relevant information I'd rather have is in an .rst file and visible on the website.
But I agree to let @ldionne decide.

ldionne requested changes to this revision.Aug 30 2021, 10:45 AM

I agree that we should eventually remove this file, however I'd rather do it gradually while making sure that the stuff it mentions has been addressed properly.

I'm fine with this once the std::allocator thing has been addressed (LWG 2447). Until then, requesting changes.

Regardless, thanks a lot for the cleanup.

libcxx/TODO.TXT
75

I am not seeing a static assertion in allocator for LWG 2447.

This revision now requires changes to proceed.Aug 30 2021, 10:45 AM
jloser added a comment.EditedAug 30 2021, 2:25 PM

I agree that we should eventually remove this file, however I'd rather do it gradually while making sure that the stuff it mentions has been addressed properly.

I'm fine with this once the std::allocator thing has been addressed (LWG 2447). Until then, requesting changes.

Regardless, thanks a lot for the cleanup.

LWG 2447 is marked complete according to the issues docs. I agree with you though that it doesn't seem to be implemented. I'll keep the LWG 2447 note in this TODO.txt, but I think we should also unmark it as Complete in the docs linked previously. Want me to do that in this diff or a separate patch?

jloser updated this revision to Diff 369554.Aug 30 2021, 2:31 PM

Bring back LWG 2447 note in the TODO.txt

ldionne accepted this revision.Aug 31 2021, 6:50 AM

I agree that we should eventually remove this file, however I'd rather do it gradually while making sure that the stuff it mentions has been addressed properly.

I'm fine with this once the std::allocator thing has been addressed (LWG 2447). Until then, requesting changes.

Regardless, thanks a lot for the cleanup.

LWG 2447 is marked complete according to the issues docs. I agree with you though that it doesn't seem to be implemented. I'll keep the LWG 2447 note in this TODO.txt, but I think we should also unmark it as Complete in the docs linked previously. Want me to do that in this diff or a separate patch?

Let's ship this, but you can open a separate patch so we can look at what needs to be done for LWG 2447. Thanks!

This revision is now accepted and ready to land.Aug 31 2021, 6:50 AM
This revision was automatically updated to reflect the committed changes.