Page MenuHomePhabricator
Differential D108674

[GlobalOpt] Fix the assert for null check of global value
ClosedPublic
Actions

Authored by scui on Aug 24 2021, 4:33 PM.

Details

Reviewers
asbirlea
efriedma
Commits
rGcea5ab090b5e: [GlobalOpt] Fix the assert for null check of global value
Summary

This is to fix the reported assert - https://bugs.llvm.org/show_bug.cgi?id=51608.

Diff Detail

Event Timeline

scui created this revision.Aug 24 2021, 4:33 PM
Herald added subscribers: ormris, hiraditya. · View Herald TranscriptAug 24 2021, 4:33 PM
scui requested review of this revision.Aug 24 2021, 4:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2021, 4:33 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
asbirlea accepted this revision.Aug 24 2021, 4:41 PM

Thanks you for the fix!
The unreduced reproducer no longer asserts with it.

This revision is now accepted and ready to land.Aug 24 2021, 4:41 PM
Harbormaster completed remote builds in B121068: Diff 368495.Aug 24 2021, 5:02 PM
Closed by commit rGcea5ab090b5e: [GlobalOpt] Fix the assert for null check of global value (authored by scui). · Explain WhyAug 24 2021, 5:48 PM
This revision was automatically updated to reflect the committed changes.
scui added a commit: rGcea5ab090b5e: [GlobalOpt] Fix the assert for null check of global value.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
IPO/
5 lines
test/
Transforms/
GlobalOpt/
32 lines

Diff 368512

View Options

llvm/lib/Transforms/IPO/GlobalOpt.cpp

Loading...
View Options

llvm/test/Transforms/GlobalOpt/null-check-global-value.ll

Loading...