This is an archive of the discontinued LLVM Phabricator instance.

Differential D108518

[flang][plugins] Make `PluginParseTreeAction` an abstract class
ClosedPublic

Authored by awarzynski on Aug 22 2021, 9:34 AM.

Details

Reviewers
Meinersbur
stuartellis
Commits
rG8883db90d1ab: [flang][plugins] Make `PluginParseTreeAction` an abstract class
Summary

There's no point in providing a default implementation for
PluginParseTreeAction, so I'm making it abstract.

Diff Detail

Event Timeline

awarzynski requested review of this revision.Aug 22 2021, 9:34 AM
awarzynski created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2021, 9:34 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
awarzynski added reviewers: Meinersbur, stuartellis.Aug 22 2021, 9:42 AM
awarzynski added a project: Restricted Project.
Herald added a subscriber: jdoerfert. · View Herald TranscriptAug 22 2021, 9:42 AM
awarzynski mentioned this in D108283: [flang][driver] Add documentation for Plugins.Aug 22 2021, 9:55 AM
Harbormaster completed remote builds in B120697: Diff 367986.Aug 22 2021, 10:06 AM
Meinersbur accepted this revision.Aug 23 2021, 4:29 PM

LGTM

This revision is now accepted and ready to land.Aug 23 2021, 4:29 PM
Closed by commit rG8883db90d1ab: [flang][plugins] Make `PluginParseTreeAction` an abstract class (authored by awarzynski). · Explain WhySep 6 2021, 8:55 AM
This revision was automatically updated to reflect the committed changes.
awarzynski added a commit: rG8883db90d1ab: [flang][plugins] Make `PluginParseTreeAction` an abstract class.

Revision Contents

PathSize
flang/
include/
flang/
Frontend/
2 lines

Diff 367986

flang/include/flang/Frontend/FrontendActions.h

Show First 20 Lines • Show All 122 Lines • ▼ Show 20 Linesclass GetSymbolsSourcesAction : public PrescanAndSemaAction {
void ExecuteAction() override; void ExecuteAction() override;
}; };
class ParseSyntaxOnlyAction : public PrescanAndSemaAction { class ParseSyntaxOnlyAction : public PrescanAndSemaAction {
void ExecuteAction() override; void ExecuteAction() override;
}; };
class PluginParseTreeAction : public PrescanAndSemaAction { class PluginParseTreeAction : public PrescanAndSemaAction {
void ExecuteAction() override; void ExecuteAction() override = 0;
}; };
} // namespace Fortran::frontend } // namespace Fortran::frontend
#endif // LLVM_FLANG_FRONTEND_FRONTENDACTIONS_H #endif // LLVM_FLANG_FRONTEND_FRONTENDACTIONS_H