This is an archive of the discontinued LLVM Phabricator instance.

[Bazel] Fix version defines
ClosedPublic

Authored by GMNGeoffrey on Aug 20 2021, 4:55 PM.

Details

Summary

Some of these were the wrong version and some of them were the wrong
format. Did some hunting around to figure out what exactly they're
supposed to be. Since basically everything is derived from the LLVM
version we should probably make this a bit less hardcoded, but just
fixing the values for now.

Sources:
https://github.com/llvm/llvm-project/blob/b686fc7a1bea/clang/include/clang/Basic/Version.inc.in
https://github.com/llvm/llvm-project/blob/b686fc7a1bea/clang/CMakeLists.txt#L353-L363
https://github.com/llvm/llvm-project/blob/b686fc7a1bea/llvm/CMakeLists.txt#L13-L29
https://github.com/llvm/llvm-project/blob/b686fc7a1bea/lld/CMakeLists.txt#L131-L138

Diff Detail

Event Timeline

GMNGeoffrey requested review of this revision.Aug 20 2021, 4:55 PM
GMNGeoffrey created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2021, 4:55 PM
MaskRay accepted this revision.Aug 20 2021, 5:00 PM

Looks great!

This revision is now accepted and ready to land.Aug 20 2021, 5:00 PM
GMNGeoffrey edited the summary of this revision. (Show Details)Aug 20 2021, 5:00 PM
This revision was automatically updated to reflect the committed changes.