[Bazel] Reduce quote escaping

[GMNGeoffrey]

Summary

There's a lot of unnecessary backslashes here that we can avoid to
reduce confusion.

[MaskRay]

LGTM.

utils/bazel/llvm-project-overlay/clang/BUILD.bazel

347

BTW, it is 14.0.0 now. The change should be separate.

utils/bazel/llvm-project-overlay/clang/BUILD.bazel

 
 exports_files(
     glob(["include/**/*.td"]),
 )
 
 genrule(
     name = "basic_version_gen",
     outs = ["include/clang/Basic/Version.inc"],
-    cmd = ("printf " +
-           "\"#define CLANG_VERSION 12.0\n\"" +
-           "\"#define CLANG_VERSION_MAJOR 12\n\"" +
-           "\"#define CLANG_VERSION_MINOR 0\n\"" +
-           "\"#define CLANG_VERSION_PATCHLEVEL 0\n\"" +
-           "\"#define CLANG_VERSION_STRING \\\"git\\\"\n\" > $@"),
+    cmd = (
+        "echo '#define CLANG_VERSION 12.0' >> $@\n" +
+        "echo '#define CLANG_VERSION_MAJOR 12' >> $@\n" +
+        "echo '#define CLANG_VERSION_MINOR 0' >> $@\n" +
+        "echo '#define CLANG_VERSION_PATCHLEVEL 0' >> $@\n" +
+        "echo '#define CLANG_VERSION_STRING \"git\"' >> $@\n"
+    ),
 )
 
 cc_library(
     name = "config",
     hdrs = [
         "include/clang/Basic/Version.inc",
         "include/clang/Config/config.h",
     ],
     includes = ["include"],
     deps = [
         # We rely on the LLVM config library to provide configuration defines.
         "//llvm:config",
     ],
 )
 
 # TODO: This should get replaced with something that actually generates the
 # correct version number.
 genrule(
     name = "vcs_version_gen",
     # This should be under lib/Basic, but because of how the include paths
     # are passed through bazel, it's easier to drop generated files next to
     # the other includes.
     outs = ["include/VCSVersion.inc"],
-    cmd = "echo \"#define CLANG_REVISION \\\"git\\\"\" > $@",
+    cmd = "echo '#define CLANG_REVISION \"git\"' > $@",
 )
 
 # A hacky library to expose some internal headers of the `basic` library to its
 # own implementation source files using a stripped include prefix rather than
 # file-relative-inclusion. This is inherently non-modular as these headers will
 # be repeated in the sources below for file-relative-inclusion.
 cc_library(
     name = "basic_internal_headers",

utils/bazel/llvm-project-overlay/llvm/BUILD.bazel

enum_targets_gen(
     targets = llvm_target_mcas,
 )
 
 # TODO: Need to replace this with something that actually extracts the git
 # commit from the LLVM source (submodule or http_archive).
 genrule(
     name = "version_info_gen",
     outs = ["include/llvm/Config/VersionInfo.h"],
-    cmd = "echo \"#define LLVM_VERSION_INFO \\\"git\\\"\" > $@",
+    cmd = "echo '#define LLVM_VERSION_INFO \"git\"' > $@",
 )
 
 template_rule(
     name = "abi_breaking_h_gen",
     src = "include/llvm/Config/abi-breaking.h.cmake",
     out = "include/llvm/Config/abi-breaking.h",
     substitutions = {
         # Define to enable checks that alter the LLVM C++ ABI

utils/bazel/llvm-project-overlay/llvm/config.bzl

 # This file is licensed under the Apache License v2.0 with LLVM Exceptions.
 # See https://llvm.org/LICENSE.txt for license information.
 # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 
 """Defines variables that use selects to configure LLVM based on platform."""
 
 def native_arch_defines(arch, triple):
     return [
-        "LLVM_NATIVE_ARCH=\\\"{}\\\"".format(arch),
+        r'LLVM_NATIVE_ARCH=\"{}\"'.format(arch),
         "LLVM_NATIVE_ASMPARSER=LLVMInitialize{}AsmParser".format(arch),
         "LLVM_NATIVE_ASMPRINTER=LLVMInitialize{}AsmPrinter".format(arch),
         "LLVM_NATIVE_DISASSEMBLER=LLVMInitialize{}Disassembler".format(arch),
         "LLVM_NATIVE_TARGET=LLVMInitialize{}Target".format(arch),
         "LLVM_NATIVE_TARGETINFO=LLVMInitialize{}TargetInfo".format(arch),
         "LLVM_NATIVE_TARGETMC=LLVMInitialize{}TargetMC".format(arch),
         "LLVM_NATIVE_TARGETMCA=LLVMInitialize{}TargetMCA".format(arch),
-        "LLVM_HOST_TRIPLE=\\\"{}\\\"".format(triple),
-        "LLVM_DEFAULT_TARGET_TRIPLE=\\\"{}\\\"".format(triple),
+        r'LLVM_HOST_TRIPLE=\"{}\"'.format(triple),
+        r'LLVM_DEFAULT_TARGET_TRIPLE=\"{}\"'.format(triple),
     ]
 
 posix_defines = [
     "LLVM_ON_UNIX=1",
     "HAVE_BACKTRACE=1",
     "BACKTRACE_HEADER=<execinfo.h>",
-    "LTDL_SHLIB_EXT=\\\".so\\\"",
-    "LLVM_PLUGIN_EXT=\\\".so\\\"",
+    r'LTDL_SHLIB_EXT=\".so\"',
+    r'LLVM_PLUGIN_EXT=\".so\"',
     "LLVM_ENABLE_THREADS=1",
     "HAVE_SYSEXITS_H=1",
     "HAVE_UNISTD_H=1",
     "HAVE_STRERROR_R=1",
     "HAVE_LIBPTHREAD=1",
     "HAVE_PTHREAD_GETNAME_NP=1",
     "HAVE_PTHREAD_SETNAME_NP=1",
     "HAVE_PTHREAD_GETSPECIFIC=1",

 ]
 
 win32_defines = [
     # MSVC specific
     "stricmp=_stricmp",
     "strdup=_strdup",
 
     # LLVM features
-    "LTDL_SHLIB_EXT=\\\".dll\\\"",
-    "LLVM_PLUGIN_EXT=\\\".dll\\\"",
+    r'LTDL_SHLIB_EXT=\".dll\"',
+    r'LLVM_PLUGIN_EXT=\".dll\"',
 ]
 
 # TODO: We should switch to platforms-based config settings to make this easier
 # to express.
 os_defines = select({
     "@bazel_tools//src/conditions:windows": win32_defines,
     "@bazel_tools//src/conditions:darwin": macos_defines,
     "//conditions:default": linux_defines,