This is an archive of the discontinued LLVM Phabricator instance.

Differential D108364

Fix CodeGen/X86/fsafdo_test2.ll fail in release
ClosedPublic

Authored by thopre on Aug 19 2021, 4:07 AM.

Download Raw Diff

Details

Reviewers

xur
wmi
wenlei
hoy

Commits

rG9d476f0af9a4: Fix CodeGen/X86/fsafdo_test2.ll fail in release

Summary

Require debug build for CodeGen/X86/fsafdo_test2.ll since it checks for
messages only printed in debug mode.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

thopre created this revision.Aug 19 2021, 4:07 AM

Herald added a subscriber: pengfei. · View Herald TranscriptAug 19 2021, 4:07 AM

thopre requested review of this revision.Aug 19 2021, 4:07 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2021, 4:07 AM

Harbormaster completed remote builds in B120299: Diff 367450.Aug 19 2021, 5:09 AM

hoy accepted this revision.Aug 19 2021, 8:49 AM

This revision is now accepted and ready to land.Aug 19 2021, 8:49 AM

Lgtm, thanks for the fix.

wenlei accepted this revision.Aug 19 2021, 8:50 AM

Closed by commit rG9d476f0af9a4: Fix CodeGen/X86/fsafdo_test2.ll fail in release (authored by thopre). · Explain WhyAug 19 2021, 8:54 AM

This revision was automatically updated to reflect the committed changes.

thopre added a commit: rG9d476f0af9a4: Fix CodeGen/X86/fsafdo_test2.ll fail in release.

wenlei mentioned this in D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.Aug 19 2021, 9:15 AM

Thanks for the fix!

-Rong

Revision Contents

Path

Size

llvm/

test/

CodeGen/

X86/

fsafdo_test2.ll

1 line

Diff 367520

llvm/test/CodeGen/X86/fsafdo_test2.ll

				; REQUIRES: asserts
	; RUN: llc -enable-fs-discriminator < %s \| FileCheck %s			; RUN: llc -enable-fs-discriminator < %s \| FileCheck %s
	; RUN: llvm-profdata merge --sample -profile-isfs -o %t.afdo %S/Inputs/fsloader.afdo			; RUN: llvm-profdata merge --sample -profile-isfs -o %t.afdo %S/Inputs/fsloader.afdo
	; RUN: llc -enable-fs-discriminator -fs-profile-file=%t.afdo -show-fs-branchprob -disable-ra-fsprofile-loader=false -disable-layout-fsprofile-loader=false < %s 2>&1 \| FileCheck %s --check-prefix=LOADER			; RUN: llc -enable-fs-discriminator -fs-profile-file=%t.afdo -show-fs-branchprob -disable-ra-fsprofile-loader=false -disable-layout-fsprofile-loader=false < %s 2>&1 \| FileCheck %s --check-prefix=LOADER
	;			;
	;;			;;
	;; C source code for the test (compiler at -O3):			;; C source code for the test (compiler at -O3):
	;; // A test case for loop unroll.			;; // A test case for loop unroll.
	;;			;;
	▲ Show 20 Lines • Show All 247 Lines • Show Last 20 Lines