This is an archive of the discontinued LLVM Phabricator instance.

[llvm-cov] Correctly export branch coverage in LCOV format
ClosedPublic

Authored by fetzerch on Aug 19 2021, 2:35 AM.

Details

Summary

Commit 9f2967bcfe2f7d1fc02281f0098306c90c2c10a5 introduced support for
branch coverage including export to the LCOV format.

This commit corrects the LCOV field name for branches from BFH to BRH.
The mistake seems to have slipped in as typo because the correct field
name BRH is used in the comment section at the beginning of the file.

See also https://github.com/linux-test-project/lcov/blob/d100e6cdd4c67cbe5322fa26b2ee8aa34ea7ebcf/man/geninfo.1#L561
for the LCOV format specification.

Diff Detail

Event Timeline

fetzerch requested review of this revision.Aug 19 2021, 2:35 AM
fetzerch created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptAug 19 2021, 2:35 AM

Thank you for catching this! LGTM. Can you please ensure this defect fix blocks 12.x and 13.x release branches as well?

alanphipps accepted this revision.Aug 19 2021, 7:36 AM
This revision is now accepted and ready to land.Aug 19 2021, 7:36 AM

Thanks! This is my first contribution to LLVM and I don't have commit permissions. Could you or some of the maintainers please commit it on my behalf (Christian Fetzer <christian.fetzer@bmw.de>)? What would I need to do to 'block 12.x and 13.x release branches'?

Thanks! This is my first contribution to LLVM and I don't have commit permissions. Could you or some of the maintainers please commit it on my behalf (Christian Fetzer <christian.fetzer@bmw.de>)? What would I need to do to 'block 12.x and 13.x release branches'?

Certainly, I can commit this for you with you as author. It'll probably be within the next day or so.

For the 12.x/13.x release branches, it requires creating a bugzilla record and noting the commit. I've done this once before, but I'll take care of it.

Thanks! This is my first contribution to LLVM and I don't have commit permissions. Could you or some of the maintainers please commit it on my behalf (Christian Fetzer <christian.fetzer@bmw.de>)? What would I need to do to 'block 12.x and 13.x release branches'?

Certainly, I can commit this for you with you as author. It'll probably be within the next day or so.

For the 12.x/13.x release branches, it requires creating a bugzilla record and noting the commit. I've done this once before, but I'll take care of it.

Thanks, much appreciated!