This is an archive of the discontinued LLVM Phabricator instance.

Update bazel examples.
ClosedPublic

Authored by csigg on Aug 17 2021, 1:12 PM.

Details

Diff Detail

Event Timeline

csigg created this revision.Aug 17 2021, 1:12 PM
csigg requested review of this revision.Aug 17 2021, 1:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2021, 1:12 PM
csigg updated this revision to Diff 366997.Aug 17 2021, 1:13 PM

Put back bazel_skylib.

GMNGeoffrey accepted this revision.Aug 17 2021, 2:00 PM

LGTM with a few fixes

utils/bazel/examples/http_archive/WORKSPACE
30

I believe this has been deprecated since initial release (https://docs.bazel.build/versions/0.17.1/be/workspace.html#new_http_archive) and removed since 0.23.0 (https://docs.bazel.build/versions/0.23.0/be/workspace.html). You should just be able to use http_archive

38

This was broken before too, but we need to import llvm_disable_optional_support_deps as well

utils/bazel/examples/submodule/WORKSPACE
27

Same as above. We should be loading llvm_disable_optional_support_deps here

This revision is now accepted and ready to land.Aug 17 2021, 2:00 PM
GMNGeoffrey added inline comments.Aug 17 2021, 2:08 PM
utils/bazel/examples/submodule/WORKSPACE
21

Nit: I think I prefer not calling this "archive" here. It's not an archive in this case. I thought llvm-raw was a decent name that worked for both submodule and http_archive.

GMNGeoffrey requested changes to this revision.Aug 17 2021, 2:44 PM

Per comment on https://reviews.llvm.org/D107714 this new format actually breaks the repository rules for setting up dependencies. I'm going to revert that commit for now and we should hold off on this too

This revision now requires changes to proceed.Aug 17 2021, 2:44 PM
csigg edited the summary of this revision. (Show Details)Aug 19 2021, 12:45 AM
csigg updated this revision to Diff 367415.Aug 19 2021, 12:46 AM
csigg edited the summary of this revision. (Show Details)

Rebase.

csigg updated this revision to Diff 367416.Aug 19 2021, 12:47 AM

Actually rebase.

Thanks Geoffrey, sorry that my first attempt was quite sloppy. Could you take another look?

GMNGeoffrey accepted this revision.Aug 19 2021, 8:15 AM

Thanks Geoffrey, sorry that my first attempt was quite sloppy. Could you take another look?

Not at all! Thanks for this cleanup :-) I was somewhat at a loss for how to avoid the double http_archive thing.

This revision is now accepted and ready to land.Aug 19 2021, 8:15 AM
This revision was automatically updated to reflect the committed changes.