This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add a trivial implementation for bcmp
ClosedPublic

Authored by gchatelet on Aug 17 2021, 10:59 AM.

Diff Detail

Event Timeline

gchatelet created this revision.Aug 17 2021, 10:59 AM
gchatelet requested review of this revision.Aug 17 2021, 10:59 AM

LGTM. We need to add an entry for bcmp here to keep the integration tests running: https://github.com/llvm/llvm-project/blob/main/libc/spec/llvm_libc_ext.td

libc/src/string/bcmp.cpp
18

Nit: Since the body of the for loop is more than one line, we should add braces.

gchatelet updated this revision to Diff 367429.Aug 19 2021, 2:09 AM
gchatelet marked an inline comment as done.
  • Address comments and rebase
gchatelet updated this revision to Diff 367430.Aug 19 2021, 2:13 AM
  • Use ConstVoidPtr instead of VoidPtr
sivachandra accepted this revision.Aug 19 2021, 7:48 AM
This revision is now accepted and ready to land.Aug 19 2021, 7:48 AM
This revision was landed with ongoing or failed builds.Aug 19 2021, 10:55 AM
This revision was automatically updated to reflect the committed changes.