This is an archive of the discontinued LLVM Phabricator instance.

Differential D108064

[hwasan] Ignore lit config.enable_aliases on non-x86.
ClosedPublic

Authored by eugenis on Aug 13 2021, 5:47 PM.

Details

Reviewers
pcc
morehouse
vitalybuka
Commits
rG8c23669eeb18: [hwasan] Ignore lit config.enable_aliases on non-x86.
Summary

This re-enables a number of Android tests that have been lost in
check-hwasan.

Diff Detail

Event Timeline

eugenis created this revision.Aug 13 2021, 5:47 PM
Herald added a subscriber: jeroen.dobbelaere. · View Herald TranscriptAug 13 2021, 5:47 PM
eugenis requested review of this revision.Aug 13 2021, 5:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2021, 5:47 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
pcc accepted this revision.Aug 13 2021, 7:00 PM

LGTM

This revision is now accepted and ready to land.Aug 13 2021, 7:00 PM
Harbormaster completed remote builds in B119527: Diff 366385.Aug 13 2021, 8:06 PM
morehouse accepted this revision.Aug 16 2021, 8:02 AM

LGTM

Closed by commit rG8c23669eeb18: [hwasan] Ignore lit config.enable_aliases on non-x86. (authored by eugenis). · Explain WhyAug 16 2021, 1:39 PM
This revision was automatically updated to reflect the committed changes.
eugenis added a commit: rG8c23669eeb18: [hwasan] Ignore lit config.enable_aliases on non-x86..

Revision Contents

PathSize
compiler-rt/
test/
hwasan/
2 lines

Diff 366732

compiler-rt/test/hwasan/lit.cfg.py

Show All 9 Lines
# Setup default compiler flags used with -fsanitize=memory option. # Setup default compiler flags used with -fsanitize=memory option.
clang_cflags = [config.target_cflags] + config.debug_info_flags clang_cflags = [config.target_cflags] + config.debug_info_flags
clang_cxxflags = config.cxx_mode_flags + clang_cflags clang_cxxflags = config.cxx_mode_flags + clang_cflags
clang_hwasan_common_cflags = clang_cflags + ["-fsanitize=hwaddress", "-fuse-ld=lld"] clang_hwasan_common_cflags = clang_cflags + ["-fsanitize=hwaddress", "-fuse-ld=lld"]
if config.target_arch == 'x86_64' and config.enable_aliases == '1': if config.target_arch == 'x86_64' and config.enable_aliases == '1':
clang_hwasan_common_cflags += ["-fsanitize-hwaddress-experimental-aliasing"] clang_hwasan_common_cflags += ["-fsanitize-hwaddress-experimental-aliasing"]
if config.enable_aliases != '1': else:
config.available_features.add('pointer-tagging') config.available_features.add('pointer-tagging')
if config.target_arch == 'x86_64': if config.target_arch == 'x86_64':
# This does basically the same thing as tagged-globals on aarch64. Because # This does basically the same thing as tagged-globals on aarch64. Because
# the x86_64 implementation is for testing purposes only there is no # the x86_64 implementation is for testing purposes only there is no
# equivalent target feature implemented on x86_64. # equivalent target feature implemented on x86_64.
clang_hwasan_common_cflags += ["-mcmodel=large"] clang_hwasan_common_cflags += ["-mcmodel=large"]
# The callback instrumentation used on x86_64 has a 1/64 chance of choosing a # The callback instrumentation used on x86_64 has a 1/64 chance of choosing a
Show All 37 Lines