[clang] Fix warning -Wnon-virtual-dtor.

[akuegel]

Summary

When making the emit function virtual, the destructor needs to become
virtual as well.

[bkramer]

thanks

[akuegel]

Already landed as https://github.com/llvm/llvm-project/commit/19bd806a1a443e4ce45ccc670861848fb1579022, I will close this.

[• Quuxplusone]

clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp

311

Tip: When you're putting a defaulted virtual destructor in a derived class "just to make sure the base class's dtor was virtual," I recommend doing it with the override keyword:

~OpenCLBuiltinTestEmitter() override = default;

This way, if the base class dtor was somehow not virtual, then you'll get a nice compiler error.

clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp

private:
   MapVector<BuiltinIndexListTy *, BuiltinTableEntries> SignatureListMap;
 };
 
 /// Base class for emitting a file (e.g. header or test) from OpenCLBuiltins.td
 class OpenCLBuiltinFileEmitterBase {
 public:
   OpenCLBuiltinFileEmitterBase(RecordKeeper &Records, raw_ostream &OS)
       : Records(Records), OS(OS) {}
+  virtual ~OpenCLBuiltinFileEmitterBase() = default;
 
   // Entrypoint to generate the functions for testing all OpenCL builtin
   // functions.
   virtual void emit() = 0;
 
 protected:
   struct TypeFlags {
     TypeFlags() : IsConst(false), IsVolatile(false), IsPointer(false) {}

 
 // OpenCL builtin test generator.  This class processes the same TableGen input
 // as BuiltinNameEmitter, but generates a .cl file that contains a call to each
 // builtin function described in the .td input.
 class OpenCLBuiltinTestEmitter : public OpenCLBuiltinFileEmitterBase {
 public:
   OpenCLBuiltinTestEmitter(RecordKeeper &Records, raw_ostream &OS)
       : OpenCLBuiltinFileEmitterBase(Records, OS) {}
+  virtual ~OpenCLBuiltinTestEmitter() = default;
 
   // Entrypoint to generate the functions for testing all OpenCL builtin
   // functions.
   void emit() override;
 };
 
 } // namespace