[MC][ELF] Mark Solaris objects as ELFOSABI_SOLARIS

[ro]

Summary

Prompted by D107747, it seems prudent to mark objects as ELFOSABI_SOLARIS on
Solaris.

Tested on amd64-pc-solaris2.11 and sparcv9-sun-solaris2.11.

[MaskRay]

Needs a test. test/MC/ELF/section-gnu.s is a reference.

[ro]

Add testcase.

[ro]

In D107748#2934871, @MaskRay wrote:

Needs a test. test/MC/ELF/section-gnu.s is a reference.

Like the attached? Right now, we cannot do much more than check that ELFOSABI_SOLARIS is emitted for *-solaris triples.

[MaskRay]

LGTM.

llvm/test/MC/ELF/osabi-solaris.s

1

Drop. The whole directory requires x86.

2

-triple=amd64-solaris

Use = or consistently

5

unneeded

[ro]

llvm/test/MC/ELF/osabi-solaris.s

1

Ah, I missed the lit.local.cfg file.

2

I've gone for ' ', but the whole directory is a mess:

-filetype: 228 x '=', 4 x ' '
-triple: 41 x '=', 223 x ' '

[ro]

Incorporate review comments for osabi-solaris.s.

llvm/include/llvm/MC/MCELFObjectWriter.h

static uint8_t getOSABI(Triple::OSType OSType) {
     switch (OSType) {
       case Triple::CloudABI:
         return ELF::ELFOSABI_CLOUDABI;
       case Triple::HermitCore:
         return ELF::ELFOSABI_STANDALONE;
       case Triple::PS4:
       case Triple::FreeBSD:
         return ELF::ELFOSABI_FREEBSD;
+      case Triple::Solaris:
+        return ELF::ELFOSABI_SOLARIS;
       default:
         return ELF::ELFOSABI_NONE;
     }
   }
 
   virtual unsigned getRelocType(MCContext &Ctx, const MCValue &Target,
                                 const MCFixup &Fixup, bool IsPCRel) const = 0;
 

llvm/test/MC/ELF/osabi-solaris.s

+# REQUIRES: x86-registered-target
+# RUN: llvm-mc -filetype=obj -triple amd64-solaris %s | llvm-readobj -hS - | FileCheck %s
+# CHECK: OS/ABI: Solaris
+
+.text