This is an archive of the discontinued LLVM Phabricator instance.

[LLVM][IR][NFC] Simplify writeDIGenericSubrange
ClosedPublic

Authored by gAlfonso-bit on Aug 4 2021, 8:13 AM.

Details

Reviewers
dexonsmith
MaskRay
Group Reviewers
Restricted Project
Commits
rG17bc82dd3be9: [AsmWriter][NFC] Simplify writeDIGenericSubrange
Summary

The expression at the end is needlessly complex so I have simplified it.

Diff Detail

Event Timeline

gAlfonso-bit created this revision.Aug 4 2021, 8:13 AM
gAlfonso-bit requested review of this revision.Aug 4 2021, 8:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2021, 8:13 AM
gAlfonso-bit retitled this revision from Reword writeDIGenericSubrange to [IR][NFC] Reword writeDIGenericSubrange.Aug 4 2021, 8:14 AM
gAlfonso-bit added a reviewer: Restricted Project.
gAlfonso-bit retitled this revision from [IR][NFC] Reword writeDIGenericSubrange to [LLVM}[IR][NFC] Reword writeDIGenericSubrange.Aug 4 2021, 8:19 AM
gAlfonso-bit retitled this revision from [LLVM}[IR][NFC] Reword writeDIGenericSubrange to [LLVM][IR][NFC] Reword writeDIGenericSubrange.Aug 4 2021, 8:27 AM
gAlfonso-bit retitled this revision from [LLVM][IR][NFC] Reword writeDIGenericSubrange to [LLVM][IR][NFC] Simplify writeDIGenericSubrange.Aug 5 2021, 12:46 PM
gAlfonso-bit edited the summary of this revision. (Show Details)
gAlfonso-bit updated this revision to Diff 364593.EditedAug 5 2021, 1:10 PM

Added context to patch

gAlfonso-bit edited reviewers, added: dexonsmith; removed: MaskRay.
MaskRay accepted this revision.Aug 12 2021, 6:02 PM
This revision is now accepted and ready to land.Aug 12 2021, 6:02 PM
This revision was landed with ongoing or failed builds.Aug 13 2021, 9:31 AM
This revision was automatically updated to reflect the committed changes.