This is an archive of the discontinued LLVM Phabricator instance.

[llvm][ExecutionEngine] Don't try to run tests on ARM64/Windows on Arm
ClosedPublic

Authored by DavidSpickett on Aug 3 2021, 8:21 AM.

Details

Summary

We use CMAKE_SYSTEM_PROCESSOR to set the host_arch lit feature.
This is going to be the same value as CMAKE_HOST_SYSTEM_PROCESSOR,
which on windows is set to the value of the PROCESSOR_ARCHITECTURE
environment variable.

https://cmake.org/cmake/help/latest/variable/CMAKE_HOST_SYSTEM_PROCESSOR.html#cmake-host-system-processor

On Windows on Arm this is "ARM64", not "AArch64" as we currently
look for.

https://docs.microsoft.com/en-us/windows/win32/winprog64/wow64-implementation-details#environment-variables

Add ARM64 to the unsupported list.

Diff Detail

Event Timeline

DavidSpickett created this revision.Aug 3 2021, 8:21 AM
DavidSpickett requested review of this revision.Aug 3 2021, 8:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2021, 8:21 AM

In case you wondered why this is coming up now, we (Linaro) have build bots for Windows on Arm but the tests are disabled right now. I'm going through and fixing all the failures so we can enable them.

lhames accepted this revision.Aug 3 2021, 5:22 PM

LGTM. Thanks David!

Do you have commit access? If not please let me know and I can commit on your behalf.

This revision is now accepted and ready to land.Aug 3 2021, 5:22 PM

I've got access, I'll land this shortly.