[LLD][MinGW] Accept joined format for --stack

[mati865]

Summary

Postgresql uses --stack= in it's Makefile.

Downstream issue: https://github.com/msys2/MINGW-packages/pull/9167

[mstorsjo]

LGTM, thanks!

From a quick look at the options listing, I presume most other cases of S<> and J<…=> should be changed into Eq<> too.

[mstorsjo]

(Marking as approved too.)

[mati865]

From a quick look at the options listing, I presume most other cases of S<> and J<…=> should be changed into Eq<> too.

It's very likely but I don't know how to easily check it with BFD and I think this was the only problematic flag recently.

[jeremyd2019]

In D107237#2918766, @mati865 wrote:

From a quick look at the options listing, I presume most other cases of S<> and J<…=> should be changed into Eq<> too.

It's very likely but I don't know how to easily check it with BFD and I think this was the only problematic flag recently.

lld: error: unknown argument: --image-base=0x10000000 ?

[mstorsjo]

In D107237#2918830, @jeremyd2019 wrote:

In D107237#2918766, @mati865 wrote:

From a quick look at the options listing, I presume most other cases of S<> and J<…=> should be changed into Eq<> too.

It's very likely but I don't know how to easily check it with BFD and I think this was the only problematic flag recently.

lld: error: unknown argument: --image-base=0x10000000 ?

Yes, that shows that lld doesn't support that form of that option - the question is whether ld.bfd supports that form of that particular option (I would assume it does as it uses getopt iirc).

Other than those two, there's also --major-image-version/--minor-image-version (which lld currently just ignores), and -mllvm (which only has correspondence in the lld ELF backend, where it supports both option forms), and --icf (which only is supported in the --icf=<foo> form currently. Additionally the option definitions of plugin and plugin-opt could be simplified.

[jeremyd2019]

In D107237#2918836, @mstorsjo wrote:

In D107237#2918830, @jeremyd2019 wrote:

lld: error: unknown argument: --image-base=0x10000000 ?

Yes, that shows that lld doesn't support that form of that option - the question is whether ld.bfd supports that form of that particular option (I would assume it does as it uses getopt iirc).

That's an error from a couple of actual packages (meanwhile and openldap)

[mstorsjo]

In D107237#2918897, @jeremyd2019 wrote:

In D107237#2918836, @mstorsjo wrote:

In D107237#2918830, @jeremyd2019 wrote:

lld: error: unknown argument: --image-base=0x10000000 ?

Yes, that shows that lld doesn't support that form of that option - the question is whether ld.bfd supports that form of that particular option (I would assume it does as it uses getopt iirc).

That's an error from a couple of actual packages (meanwhile and openldap)

Oh, ok, so those would be more low hanging fruit to fix by doing the same for that option.

lld/MinGW/Options.td

def large_address_aware: Flag<["--"], "large-address-aware">,
     HelpText<"Enable large addresses">;
 def o: JoinedOrSeparate<["-"], "o">, MetaVarName<"<path>">,
   HelpText<"Path to file to write output">;
 defm out_implib: Eq<"out-implib", "Import library name">;
 defm output_def: Eq<"output-def", "Output def file">;
 defm section_alignment: Eq<"section-alignment", "Set section alignment">;
 def shared: F<"shared">, HelpText<"Build a shared object">;
 defm subs: Eq<"subsystem", "Specify subsystem">;
-def stack: S<"stack">;
+defm stack: Eq<"stack", "Set size of the initial stack">;
 def strip_all: F<"strip-all">,
     HelpText<"Omit all symbol information from the output binary">;
 def strip_debug: F<"strip-debug">,
     HelpText<"Omit all debug information, but keep symbol information">;
 defm reproduce: Eq<"reproduce",
      "Write a tar file containing input files and command line options to reproduce link">;
 defm require_defined: Eq<"require-defined",
      "Force symbol to be added to symbol table as an undefined one">;

lld/test/MinGW/driver.test

 RUN: ld.lld -### foo.o -m i386pep --subsystem windows:2.3 --major-subsystem-version 7 --minor-subsystem-version 8 2>&1 | FileCheck -check-prefix=SUBSYSTEM_WINDOWS %s
 RUN: ld.lld -### foo.o -m i386pep --subsystem windows:7.8 2>&1 | FileCheck -check-prefix=SUBSYSTEM_WINDOWS %s
 RUN: ld.lld -### foo.o -m i386pep --major-subsystem-version 2 --minor-subsystem-version 3 --subsystem windows:7.8 2>&1 | FileCheck -check-prefix=SUBSYSTEM_WINDOWS %s
 RUN: ld.lld -### foo.o -m i386pep --major-subsystem-version 2 --minor-subsystem-version 8 --subsystem windows:7 2>&1 | FileCheck -check-prefix=SUBSYSTEM_WINDOWS %s
 SUBSYSTEM_WINDOWS: -subsystem:windows,7.8
 
 RUN: ld.lld -### foo.o -m i386pep -stack 4194304,8192 2>&1 | FileCheck -check-prefix=STACK %s
 RUN: ld.lld -### foo.o -m i386pep --stack 4194304,8192 2>&1 | FileCheck -check-prefix=STACK %s
+RUN: ld.lld -### foo.o -m i386pep --stack=4194304,8192 2>&1 | FileCheck -check-prefix=STACK %s
 STACK: -stack:4194304,8192
 
 RUN: ld.lld -### foo.o -m i386pep -verbose 2>&1 | FileCheck -check-prefix=VERBOSE %s
 RUN: ld.lld -### foo.o -m i386pep --verbose 2>&1 | FileCheck -check-prefix=VERBOSE %s
 VERBOSE: -verbose
 
 RUN: ld.lld -### -shared -m i386pe -e _DllMainCRTStartup@12 foo.o 2>&1 | FileCheck -check-prefix I386-ENTRY %s
 I386-ENTRY: -entry:DllMainCRTStartup@12