This is an archive of the discontinued LLVM Phabricator instance.

Differential D107123

[Bazel] Unconditionally define STDC LIMIT/CONSTANT/FORMAT
ClosedPublic

Authored by GMNGeoffrey on Jul 29 2021, 5:43 PM.

Details

Reviewers
chandlerc
rsmith
Commits
rGf3a8a7b91e54: [Bazel] Unconditionally define STDC LIMIT/CONSTANT/FORMAT
Summary

These are unconditionally included in the CMake build as well and
necessary for some odd platforms (even though the C++11 standard says
they shouldn't be).

Diff Detail

Event Timeline

GMNGeoffrey requested review of this revision.Jul 29 2021, 5:43 PM
GMNGeoffrey created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2021, 5:43 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B117082: Diff 362935.Jul 29 2021, 5:45 PM
chandlerc accepted this revision.Jul 29 2021, 6:08 PM

LGTM

This revision is now accepted and ready to land.Jul 29 2021, 6:08 PM
Closed by commit rGf3a8a7b91e54: [Bazel] Unconditionally define STDC LIMIT/CONSTANT/FORMAT (authored by GMNGeoffrey). · Explain WhyJul 29 2021, 6:12 PM
This revision was automatically updated to reflect the committed changes.
GMNGeoffrey added a commit: rGf3a8a7b91e54: [Bazel] Unconditionally define STDC LIMIT/CONSTANT/FORMAT.

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
llvm/
11 lines

Diff 362935

utils/bazel/llvm-project-overlay/llvm/config.bzl

Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines
}) })
# TODO: We should split out host vs. target here. # TODO: We should split out host vs. target here.
llvm_config_defines = os_defines + select({ llvm_config_defines = os_defines + select({
"@bazel_tools//src/conditions:windows": native_arch_defines("X86", "x86_64-pc-win32"), "@bazel_tools//src/conditions:windows": native_arch_defines("X86", "x86_64-pc-win32"),
"@bazel_tools//src/conditions:darwin": native_arch_defines("X86", "x86_64-unknown-darwin"), "@bazel_tools//src/conditions:darwin": native_arch_defines("X86", "x86_64-unknown-darwin"),
"@bazel_tools//src/conditions:linux_aarch64": native_arch_defines("AArch64", "aarch64-unknown-linux-gnu"), "@bazel_tools//src/conditions:linux_aarch64": native_arch_defines("AArch64", "aarch64-unknown-linux-gnu"),
"//conditions:default": native_arch_defines("X86", "x86_64-unknown-linux-gnu"), "//conditions:default": native_arch_defines("X86", "x86_64-unknown-linux-gnu"),
}) }) + [
# These shouldn't be needed by the C++11 standard, but are for some
# platforms (e.g. glibc < 2.18. See
# https://sourceware.org/bugzilla/show_bug.cgi?id=15366). These are also
# included unconditionally in the CMake build:
# https://github.com/llvm/llvm-project/blob/cd0dd8ece8e/llvm/cmake/modules/HandleLLVMOptions.cmake#L907-L909
"__STDC_LIMIT_MACROS",
"__STDC_CONSTANT_MACROS",
"__STDC_FORMAT_MACROS",
]